the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2607046332
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergSchemaExtractor.java:
##########
@@ -1044,4 +1044,55 @@ public void testToIcebergWithNoFieldIdsSet() {
Assertions.assertTrue(
icebergRepresentation.sameSchema(SCHEMA_EXTRACTOR.toIceberg(internalSchema)));
}
+
+ @Test
+ public void testToIcebergWithPartialFieldIdsSet() {
+ InternalSchema internalSchema =
+ InternalSchema.builder()
+ .name("testRecord")
+ .dataType(InternalType.RECORD)
+ .isNullable(false)
+ .fields(
Review Comment:
Let's add another field that comes after the list to ensure the next field
ID is chosen properly. For example, the field after the list is going to have
ID 3. We want to make sure that this carries through to the Iceberg schema.
Let's make sure the Map case is also tested here to ensure there is no
regression in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
