emilie-wang commented on code in PR #769:
URL: https://github.com/apache/incubator-xtable/pull/769#discussion_r2620566562
##########
xtable-core/src/test/java/org/apache/xtable/testutil/ColumnStatMapUtil.java:
##########
@@ -343,7 +362,21 @@ public static List<ColumnStat> getColumnStats() {
.numValues(50)
.totalSize(123)
.build();
+ ColumnStat nestedStringColumnStats =
+ ColumnStat.builder()
+ .field(NESTED_STRING_FIELD)
+ .numNulls(1)
+ .range(Range.vector("alice", "zion"))
Review Comment:
Good callout! The test actually uses this `getAllFields()` and it is already
included the nested string field, meanwhile the expected stats also include
this stats.
https://github.com/apache/incubator-xtable/blob/27f6a162082a04c21755ff49184c34a975caef00/xtable-core/src/test/java/org/apache/xtable/delta/TestDeltaStatsExtractor.java#L121
https://github.com/apache/incubator-xtable/blob/27f6a162082a04c21755ff49184c34a975caef00/xtable-core/src/test/java/org/apache/xtable/testutil/ColumnStatMapUtil.java#L421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
