vinishjail97 commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2624493635
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,9 +169,35 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private MappedFields updateNameMapping(MappedFields mapping, Map<Integer,
String> updates) {
+ if (mapping == null) {
Review Comment:
Can mapping ever be null? If null is returned will `NameMapping.of` not
throw an exception?
##########
xtable-api/src/main/java/org/apache/xtable/model/schema/InternalField.java:
##########
@@ -43,6 +43,7 @@ public class InternalField {
// The id field for the field. This is used to identify the field in the
schema even after
// renames.
Integer fieldId;
+ @Getter String storageName;
Review Comment:
Can you add a comment for this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
