vinishjail97 commented on code in PR #772:
URL: https://github.com/apache/incubator-xtable/pull/772#discussion_r2641701276


##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -533,28 +536,31 @@ private static Stream<Arguments> 
provideArgsForPartitionTesting() {
         Arguments.of(
             buildArgsForPartition(
                 ICEBERG, Arrays.asList(DELTA, HUDI), null, "level:VALUE", 
levelFilter)),
-        Arguments.of(
-            // Delta Lake does not currently support nested partition columns
-            buildArgsForPartition(
-                HUDI,
-                Arrays.asList(ICEBERG),
-                "nested_record.level:SIMPLE",
-                "nested_record.level:VALUE",
-                nestedLevelFilter)),
+        // Different issue, didn't investigate this much at all
+        //        Arguments.of(
+        //            // Delta Lake does not currently support nested 
partition columns
+        //            buildArgsForPartition(
+        //                HUDI,
+        //                Arrays.asList(ICEBERG),
+        //                "nested_record.level:SIMPLE",
+        //                "nested_record.level:VALUE",
+        //                nestedLevelFilter)),
         Arguments.of(
             buildArgsForPartition(
                 HUDI,
                 Arrays.asList(ICEBERG, DELTA),
                 "severity:SIMPLE",
                 "severity:VALUE",
-                severityFilter)),
-        Arguments.of(
-            buildArgsForPartition(
-                HUDI,
-                Arrays.asList(ICEBERG, DELTA),
-                "timestamp_micros_nullable_field:TIMESTAMP,level:SIMPLE",
-                "timestamp_micros_nullable_field:DAY:yyyy/MM/dd,level:VALUE",
-                timestampAndLevelFilter)));
+                severityFilter)));
+    // [ENG-6555] addresses this

Review Comment:
   https://github.com/apache/incubator-xtable/issues/775 
   Hudi 1.1 and ICEBERG partitioned filter data validation fails



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to