mao-liu commented on code in PR #767:
URL: https://github.com/apache/incubator-xtable/pull/767#discussion_r2685426062
##########
xtable-core/src/test/java/org/apache/xtable/paimon/TestPaimonDataFileExtractor.java:
##########
@@ -250,32 +236,19 @@ private void createUnpartitionedTable() {
(TestPaimonTable)
TestPaimonTable.createTable("test_table", null, tempDir, new
Configuration(), false);
paimonTable = testTable.getPaimonTable();
- testSchema =
- InternalSchema.builder().build(); // empty schema won't matter for
non-partitioned tables
}
private void createPartitionedTable() {
testTable =
(TestPaimonTable)
TestPaimonTable.createTable("test_table", "level", tempDir, new
Configuration(), false);
paimonTable = testTable.getPaimonTable();
-
- // just the partition field matters for this test
Review Comment:
The previous tests did not accurately represent the schema of the test
tables - the tables had certain columns, but the "testSchema" objects were
empty.
The stats extractor sometimes need to rely on the schema to be able to parse
binary stats data from Paimon metadata, hence the change to extract the schema
properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
