kevinjqliu commented on code in PR #784:
URL: https://github.com/apache/incubator-xtable/pull/784#discussion_r2706259545
##########
xtable-core/src/test/resources/schemas/basic_schema.avsc:
##########
@@ -72,20 +72,23 @@
},
{
"name": "bytes_field",
- "type": "bytes",
- "default": ""
+ "type": ["null", "bytes"],
+ "default": null
Review Comment:
yep, fails with
```
Error:
org.apache.xtable.hudi.ITHudiConversionSource.insertAndUpsertData(HoodieTableType,
PartitionConfig)[3] -- Time elapsed: 10.34 s <<< ERROR!
org.apache.hudi.exception.HoodieInsertException: Failed to bulk insert for
commit time 20260119224246020
at
org.apache.hudi.table.action.commit.JavaBulkInsertCommitActionExecutor.execute(JavaBulkInsertCommitActionExecutor.java:63)
at
org.apache.hudi.table.HoodieJavaCopyOnWriteTable.bulkInsert(HoodieJavaCopyOnWriteTable.java:118)
at
org.apache.hudi.table.HoodieJavaCopyOnWriteTable.bulkInsert(HoodieJavaCopyOnWriteTable.java:85)
at
org.apache.hudi.client.HoodieJavaWriteClient.bulkInsert(HoodieJavaWriteClient.java:169)
at
org.apache.hudi.client.HoodieJavaWriteClient.bulkInsert(HoodieJavaWriteClient.java:158)
at
org.apache.xtable.TestJavaHudiTable.insertRecordsWithCommitAlreadyStarted(TestJavaHudiTable.java:195)
at
org.apache.xtable.hudi.ITHudiConversionSource.insertAndUpsertData(ITHudiConversionSource.java:245)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1062)
at
java.base/java.util.concurrent.ForkJoinPool.awaitJoin(ForkJoinPool.java:1688)
at
java.base/java.util.concurrent.ForkJoinTask.doJoin(ForkJoinTask.java:397)
at
java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1004)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: java.lang.RuntimeException:
org.apache.hudi.exception.HoodieException:
org.apache.hudi.exception.HoodieException: org.apache.avro.AvroTypeException:
Invalid default for field bytes_field: "" not a "bytes"
at
org.apache.hudi.client.utils.LazyIterableIterator.next(LazyIterableIterator.java:121)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at
org.apache.hudi.table.action.commit.JavaBulkInsertHelper.bulkInsert(JavaBulkInsertHelper.java:131)
at
org.apache.hudi.table.action.commit.JavaBulkInsertHelper.bulkInsert(JavaBulkInsertHelper.java:84)
at
org.apache.hudi.table.action.commit.JavaBulkInsertCommitActionExecutor.execute(JavaBulkInsertCommitActionExecutor.java:58)
... 17 more
Caused by: org.apache.hudi.exception.HoodieException:
org.apache.hudi.exception.HoodieException: org.apache.avro.AvroTypeException:
Invalid default for field bytes_field: "" not a "bytes"
at
org.apache.hudi.execution.JavaLazyInsertIterable.computeNext(JavaLazyInsertIterable.java:71)
at
org.apache.hudi.execution.JavaLazyInsertIterable.computeNext(JavaLazyInsertIterable.java:37)
at
org.apache.hudi.client.utils.LazyIterableIterator.next(LazyIterableIterator.java:119)
... 21 more
Caused by: org.apache.hudi.exception.HoodieException:
org.apache.avro.AvroTypeException: Invalid default for field bytes_field: ""
not a "bytes"
at
org.apache.hudi.common.util.queue.SimpleExecutor.execute(SimpleExecutor.java:75)
at
org.apache.hudi.execution.JavaLazyInsertIterable.computeNext(JavaLazyInsertIterable.java:67)
... 23 more
Caused by: org.apache.avro.AvroTypeException: Invalid default for field
bytes_field: "" not a "bytes"
at org.apache.avro.Schema.validateDefault(Schema.java:1719)
at org.apache.avro.Schema$Field.<init>(Schema.java:578)
at org.apache.avro.Schema$Field.<init>(Schema.java:614)
at
org.apache.hudi.avro.HoodieAvroUtils.addMetadataFields(HoodieAvroUtils.java:291)
at
org.apache.hudi.io.HoodieWriteHandle.<init>(HoodieWriteHandle.java:96)
at
org.apache.hudi.io.HoodieCreateHandle.<init>(HoodieCreateHandle.java:89)
at
org.apache.hudi.io.HoodieCreateHandle.<init>(HoodieCreateHandle.java:76)
at
org.apache.hudi.io.CreateHandleFactory.create(CreateHandleFactory.java:45)
at
org.apache.hudi.execution.CopyOnWriteInsertHandler.consume(CopyOnWriteInsertHandler.java:85)
at
org.apache.hudi.execution.CopyOnWriteInsertHandler.consume(CopyOnWriteInsertHandler.java:42)
at
org.apache.hudi.common.util.queue.SimpleExecutor.execute(SimpleExecutor.java:69)
... 24 more
```
https://github.com/apache/incubator-xtable/actions/runs/21153333020/job/60833552403?pr=784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
