sapienza88 commented on code in PR #768:
URL: https://github.com/apache/incubator-xtable/pull/768#discussion_r2765966732
##########
xtable-core/src/main/java/org/apache/xtable/parquet/ParquetDataManager.java:
##########
@@ -108,49 +87,15 @@ public List<LocatedFileStatus>
getParquetFiles(Configuration hadoopConf, String
}
}
- public Stream<ParquetFileConfig> getConfigsFromStream(
- List<LocatedFileStatus> fileStream, Configuration conf) {
-
- return fileStream.stream()
- .map(
- fileStatus -> {
- Path path = fileStatus.getPath();
-
- ParquetMetadata metadata =
-
ParquetMetadataExtractor.getInstance().readParquetMetadata(conf, path);
-
- return ParquetFileConfig.builder()
- .schema(metadata.getFileMetaData().getSchema())
- .metadata(metadata)
- .path(path)
- .size(fileStatus.getLen())
- .modificationTime(fileStatus.getModificationTime())
- .rowGroupIndex(metadata.getBlocks().size())
- .codec(
- metadata.getBlocks().isEmpty()
- ? null
- :
metadata.getBlocks().get(0).getColumns().get(0).getCodec())
- .build();
- });
+ Stream<ParquetFileInfo> getCurrentFileInfo() {
Review Comment:
@the-other-tim-brown You would want to rename this to the plural
(getCurrentFilesInfo())?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
