vinishjail97 commented on code in PR #799:
URL: https://github.com/apache/incubator-xtable/pull/799#discussion_r2767303708
##########
xtable-core/src/main/java/org/apache/xtable/hudi/HudiSourceConfig.java:
##########
@@ -84,4 +90,30 @@ public PathBasedPartitionSpecExtractor
loadSourcePartitionSpecExtractor() {
return ReflectionUtils.createInstanceOfClass(
partitionSpecExtractorClass, this.getPartitionFieldSpecs());
}
+
+ public static boolean getOmitMetadataFields(Properties properties,
Configuration configuration) {
+ String propertyValue =
+ getPropertyOrNull(
+ properties, OMIT_METADATA_FIELDS_CONFIG,
HUDI_OMIT_METADATA_FIELDS_CONFIG);
+ if (propertyValue != null) {
+ return Boolean.parseBoolean(propertyValue);
+ }
+ if (configuration == null) {
+ return false;
+ }
+ String configValue = configuration.get(OMIT_METADATA_FIELDS_CONFIG);
Review Comment:
We won't find OMIT_METADATA_FIELDS_CONFIG in `hadoopConf`..so just keep the
change restricted to Properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
