the-other-tim-brown commented on code in PR #796:
URL: https://github.com/apache/incubator-xtable/pull/796#discussion_r2796575060
##########
xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java:
##########
@@ -186,12 +186,19 @@ private InternalSchema toInternalSchema(
List<InternalField> subFields = new
ArrayList<>(schema.getFields().size());
for (Schema.Field avroField : schema.getFields()) {
IdMapping idMapping = fieldNameToIdMapping.get(avroField.name());
+ String fieldDoc = avroField.doc();
+ if (fieldDoc == null) {
+ fieldDoc = avroField.getProp("comment");
Review Comment:
Is this a legacy way of adding docs to avro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
