Repository: zeppelin Updated Branches: refs/heads/branch-0.6 9e95f7a56 -> c0be57d7b
[ZEPPELIN-1091] Disable ace editor's showSettingsMenu in paragraph. ### What is this PR for? This PR prevent to show the ace editor's showSettingMenu screen. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1091 ### How should this be tested? Type "Ctrl+." on your paragraph. ### Screenshots (if appropriate) - before  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1110 from astroshim/ZEPPELIN-1091 and squashes the following commits: 9ff2886 [astroshim] rebase c736db0 [astroshim] disable showSettingsMenu (cherry picked from commit 94fa6a50d71dddc3365a142c5b532abfeb100731) Signed-off-by: Mina Lee <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c0be57d7 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c0be57d7 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c0be57d7 Branch: refs/heads/branch-0.6 Commit: c0be57d7b079a2fdac7317e4be7245f5151357af Parents: 9e95f7a Author: astroshim <[email protected]> Authored: Tue Jul 12 19:21:39 2016 +0900 Committer: Mina Lee <[email protected]> Committed: Tue Jul 19 03:41:59 2016 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c0be57d7/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index abba6bd..c113cff 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -849,6 +849,7 @@ angular.module('zeppelinWebApp') // remove binding $scope.editor.commands.bindKey('ctrl-alt-n.', null); + $scope.editor.commands.removeCommand('showSettingsMenu'); // autocomplete on 'ctrl+.'
