Repository: zeppelin Updated Branches: refs/heads/master c1e63f4da -> 7083ff8d3
[ZEPPELIN-2304] Fix vis Icon sizes in helium page ### What is this PR for? Icon size of helium vis packages doesn't fit into the container button. I attached a image. ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2304](https://issues.apache.org/jira/browse/ZEPPELIN-2304) ### How should this be tested? 1. Install 2+ vis packages. 2. Open the `#helium` page ### Screenshots (if appropriate) #### Before <img width="378" alt="2304_before" src="https://cloud.githubusercontent.com/assets/4968473/24238569/17b7dbaa-0fee-11e7-9994-39fd7700c70c.png"> #### After <img width="389" alt="2304_after" src="https://cloud.githubusercontent.com/assets/4968473/24238572/1aac7b72-0fee-11e7-934d-da4c2d864b54.png"> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1am...@gmail.com> Closes #2181 from 1ambda/ZEPPELIN-2304/fix-vis-icon-size-in-helium-page and squashes the following commits: 546f92a [1ambda] fix: Icon size of vis pkgs in helium page Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7083ff8d Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7083ff8d Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7083ff8d Branch: refs/heads/master Commit: 7083ff8d321ccd1e402935b67f69b377c5bcee3b Parents: c1e63f4 Author: 1ambda <1am...@gmail.com> Authored: Thu Mar 23 17:20:55 2017 +0900 Committer: ahyoungryu <ahyoung...@apache.org> Committed: Tue Mar 28 22:18:05 2017 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/helium/helium.css | 6 ++++++ zeppelin-web/src/app/helium/helium.html | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7083ff8d/zeppelin-web/src/app/helium/helium.css ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/helium/helium.css b/zeppelin-web/src/app/helium/helium.css index d43fc66..2e64df3 100644 --- a/zeppelin-web/src/app/helium/helium.css +++ b/zeppelin-web/src/app/helium/helium.css @@ -140,6 +140,12 @@ display: inline-block; } +.heliumVisIconButton > img { + display: block; + max-width: 100%; + height: auto; +} + .heliumLocalPackage { color: #636363; } http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7083ff8d/zeppelin-web/src/app/helium/helium.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/helium/helium.html b/zeppelin-web/src/app/helium/helium.html index 8ff223e3..8c2fe92 100644 --- a/zeppelin-web/src/app/helium/helium.html +++ b/zeppelin-web/src/app/helium/helium.html @@ -47,10 +47,10 @@ limitations under the License. data-ng-model="bundleOrder"> <div class="btn-group" data-ng-repeat="pkgName in bundleOrder" as-sortable-item> - <div class="btn btn-default btn-sm" + <button class="btn btn-default btn-sm heliumVisIconButton" ng-bind-html='defaultPackages[pkgName].pkg.icon' as-sortable-item-handle> - </div> + </button> </div> </div> <div class="saveLink"