Repository: zeppelin Updated Branches: refs/heads/master 1135fb61d -> 20b72758b
[ZEPPELIN-2330] Helium.html doesn't render spell information only in production build ### What is this PR for? Helium.html doesn't render spell information only in production build. That's because self-closed div doesn't work with `ng-bind-html` when it's minified. ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2330](https://issues.apache.org/jira/browse/ZEPPELIN-2330) ### How should this be tested? 1. Build `mvn clean package -DskipTests;` 2. Open `localhost:8080/#/helium.html` 3. Click the `Spell` tab ### Screenshots (if appropriate) #### Before ![2330](https://cloud.githubusercontent.com/assets/4968473/24493212/04338b30-1569-11e7-9b20-63eab389c9a5.gif) #### After <img width="830" alt="screen shot 2017-03-30 at 4 45 25 pm" src="https://cloud.githubusercontent.com/assets/4968473/24493204/fca731d2-1568-11e7-9550-b1e975dbdd55.png"> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1am...@gmail.com> Closes #2205 from 1ambda/ZEPPELIN-2330/cannot-render-spell-info-in-prod and squashes the following commits: f9c3a54 [1ambda] fix: DONT use self-closed DOM with bind html Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/20b72758 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/20b72758 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/20b72758 Branch: refs/heads/master Commit: 20b72758b4d1a66801a0ab06fb1a7833af2a44ee Parents: 1135fb6 Author: 1ambda <1am...@gmail.com> Authored: Sun Apr 2 20:10:47 2017 +0900 Committer: ahyoungryu <ahyoung...@apache.org> Committed: Mon Apr 3 10:59:10 2017 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/helium/helium.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/20b72758/zeppelin-web/src/app/helium/helium.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/helium/helium.html b/zeppelin-web/src/app/helium/helium.html index b960fe8..beb6191 100644 --- a/zeppelin-web/src/app/helium/helium.html +++ b/zeppelin-web/src/app/helium/helium.html @@ -143,7 +143,7 @@ limitations under the License. </a> </li> </ul> - <div class="heliumPackageDescription" ng-bind-html="getDescriptionText(pkgSearchResult)" /> + <div class="heliumPackageDescription" ng-bind-html="getDescriptionText(pkgSearchResult)"></div> <div ng-if="pkgSearchResult.pkg.type === 'SPELL' && pkgSearchResult.pkg.spell" class="spellInfo"> <div> @@ -202,4 +202,4 @@ limitations under the License. previous-text="‹" next-text="›" first-text="«" last-text="»"></pagination> </div> </div> -</div> \ No newline at end of file +</div>