Repository: zeppelin Updated Branches: refs/heads/master b87bcf5a9 -> 0d390ecae
[ZEPPELIN-2862] misalign text and icon in notebook dropdown on navbar ### What is this PR for? Currently, there is that misaligned text and icon in notebook dropdown on navbar ### What type of PR is it? [ Improvement ] ### What is the Jira issue? [ZEPPELIN-2862](https://issues.apache.org/jira/browse/ZEPPELIN-2862) ### How should this be tested? 1. Run web development mode in local. 2. Click Notebook Button on navbar. ### Screenshots (if appropriate) - Before <img width="273" alt="2017-08-15 5 07 41" src="https://user-images.githubusercontent.com/2561904/29307703-e4f29c48-81dd-11e7-89be-84c1bddb455d.png"> - After <img width="267" alt="2017-08-15 5 20 11" src="https://user-images.githubusercontent.com/2561904/29307755-0ad912ca-81de-11e7-8140-e4544dfbcdc1.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Shinhong Park <[email protected]> Closes #2538 from wishwisdom/ZEPPELIN-2862 and squashes the following commits: 2a1a0155 [Shinhong Park] fix: misalign text and icon in navbar Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0d390eca Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0d390eca Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0d390eca Branch: refs/heads/master Commit: 0d390ecaec857854c5931f1f785c60425fee9b86 Parents: b87bcf5 Author: Shinhong Park <[email protected]> Authored: Tue Aug 15 17:11:29 2017 +0900 Committer: 1ambda <[email protected]> Committed: Sun Aug 20 20:17:57 2017 +0900 ---------------------------------------------------------------------- zeppelin-web/src/components/navbar/navbar-note-list-elem.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0d390eca/zeppelin-web/src/components/navbar/navbar-note-list-elem.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/navbar/navbar-note-list-elem.html b/zeppelin-web/src/components/navbar/navbar-note-list-elem.html index cb36cfa..ad1f771 100644 --- a/zeppelin-web/src/components/navbar/navbar-note-list-elem.html +++ b/zeppelin-web/src/components/navbar/navbar-note-list-elem.html @@ -13,7 +13,7 @@ limitations under the License. --> <a class="notebook-list-item" ng-if="navbar.isFilterNote(node) && !node.children" href="#/notebook/{{node.id}}"> - <i style="font-size: 10px; margin-right: 5px;" ng-class="query.q && node.isTrash ? 'fa fa-trash-o' : 'icon-doc'" ></i> + <i style="font-size: 10px; margin-right: 2px; margin-left: 10px;" ng-class="query.q && node.isTrash ? 'fa fa-trash-o' : 'icon-doc'" ></i> <span>{{noteName(node)}}</span> </a> @@ -22,7 +22,7 @@ limitations under the License. <div ng-mouseenter="showFolderButton=true" ng-mouseleave="showFolderButton=false"> <a class="notebook-list-item" href="javascript:void(0)"> <div ng-if="node.id !== navbar.TRASH_FOLDER_ID"> - <i style="font-size: 10px; margin-right: 5px;" class="fa fa-folder"></i> + <i style="font-size: 10px; margin-right: 2px; margin-left: 10px" class="fa fa-folder"></i> <span>{{noteName(node)}}</span> <i data-toggle="modal" data-target="#noteCreateModal" ng-controller="NoteCreateCtrl as noteCreateCtrl" ng-click="noteCreateCtrl.getInterpreterSettings()" data-path="{{node.id}}" @@ -33,7 +33,7 @@ limitations under the License. </i> </div> <div ng-if="node.id === navbar.TRASH_FOLDER_ID"> - <i style="font-size: 12px; margin-right: 5px;" class="fa fa-trash-o"></i> + <i style="font-size: 12px; margin-right: 2px; margin-left: 10px;" class="fa fa-trash-o"></i> <span>Trash</span> </div> </a>
