This is an automated email from the ASF dual-hosted git repository. zjffdu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push: new f2d1d4f [ZEPPELIN-4446]. Allow to show/hide dynamics forms of paragraph f2d1d4f is described below commit f2d1d4f87e993ad05efcefd26880e98374ee314b Author: Jeff Zhang <zjf...@apache.org> AuthorDate: Sun Dec 8 14:24:17 2019 +0800 [ZEPPELIN-4446]. Allow to show/hide dynamics forms of paragraph ### What is this PR for? This PR is to allow user to hide dynamics forms of paragraph via paragraph local properties. e.g. ``` %python.ipython(hideForm=true) ``` ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4446 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ![image](https://user-images.githubusercontent.com/164491/70385202-1df4f300-19c7-11ea-9502-21a18409d058.png) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjf...@apache.org> Closes #3545 from zjffdu/ZEPPELIN-4446 and squashes the following commits: 9d63f32bc [Jeff Zhang] [ZEPPELIN-4446]. Allow to show/hide dynamics forms of paragraph --- zeppelin-web/src/app/notebook/paragraph/paragraph.html | 2 +- .../src/main/java/org/apache/zeppelin/notebook/Paragraph.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph.html index 10afd17..4d96324 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.html @@ -52,7 +52,7 @@ limitations under the License. <div> <dynamic-forms id="paragraph.id" - hide="paragraph.config.tableHide" + hide="paragraph.config.hideForm" disable="paragraph.status == 'RUNNING' || paragraph.status == 'PENDING'" actiononchange="paragraph.config.runOnSelectionChange" forms="paragraph.settings.forms" diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java index 91a77eb..5bc4dd3 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java @@ -233,6 +233,7 @@ public class Paragraph extends JobWithProgressPoller<InterpreterResult> implemen } else { this.scriptText = this.text.substring(headingSpace.length() + intpText.length() + 1).trim(); } + config.putAll(localProperties); } else { setIntpText(""); this.scriptText = this.text.trim();