Repository: incubator-zeppelin Updated Branches: refs/heads/master edb0a0f48 -> fd049a452
Fix zeppelin-web build Fix jshint warning/error break zeppelin-web build. Author: Lee moon soo <[email protected]> Closes #202 from Leemoonsoo/fix_jshint and squashes the following commits: 7065ec5 [Lee moon soo] Fix jshint error/warning Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/fd049a45 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/fd049a45 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/fd049a45 Branch: refs/heads/master Commit: fd049a45234a43f25b03b61dc8f35d6127fa9465 Parents: edb0a0f Author: Lee moon soo <[email protected]> Authored: Tue Aug 11 01:18:49 2015 -0700 Committer: Lee moon soo <[email protected]> Committed: Tue Aug 11 02:43:17 2015 -0700 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 2 +- .../src/components/noteName-create/visible.directive.js | 5 +++-- zeppelin-web/test/spec/controllers/notebook.js | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/fd049a45/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 0dfe6dc..2c17cf6 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -425,7 +425,7 @@ angular.module('zeppelinWebApp') } else { session.setMode(editorMode.scala); } - } + }; var remoteCompleter = { getCompletions : function(editor, session, pos, prefix, callback) { http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/fd049a45/zeppelin-web/src/components/noteName-create/visible.directive.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/noteName-create/visible.directive.js b/zeppelin-web/src/components/noteName-create/visible.directive.js index 8d3e9a1..de3fc35 100644 --- a/zeppelin-web/src/components/noteName-create/visible.directive.js +++ b/zeppelin-web/src/components/noteName-create/visible.directive.js @@ -29,8 +29,9 @@ angular.module('zeppelinWebApp').directive('modalvisible', function () { previsibleMethod(); }); elem.on('shown.bs.modal', function(e) { - if(scope.targetinput) - $(e.target).find('input#' + scope.targetinput ).select(); + if(scope.targetinput) { + angular.element(e.target).find('input#' + scope.targetinput ).select(); + } postVisibleMethod(); }); } http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/fd049a45/zeppelin-web/test/spec/controllers/notebook.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/test/spec/controllers/notebook.js b/zeppelin-web/test/spec/controllers/notebook.js index 48e6ba0..5dde4e2 100644 --- a/zeppelin-web/test/spec/controllers/notebook.js +++ b/zeppelin-web/test/spec/controllers/notebook.js @@ -8,7 +8,7 @@ describe('Controller: NotebookCtrl', function() { var NotebookCtrl, scope; // Initialize the controller and a mock scope - beforeEach(inject(function($controller, $rootScope, websocketMsgSrv, baseUrlSrv) { + beforeEach(inject(function($controller, $rootScope/*, websocketMsgSrv, baseUrlSrv*/) { scope = $rootScope.$new(); NotebookCtrl = $controller('NotebookCtrl', { $scope: scope
