Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 80edf58ad -> c7cf115dd


ZEPPELIN-293 notebook execution results leaking to dashboard page

Original PR https://github.com/apache/incubator-zeppelin/pull/293

When we run a paragraph, and without it completing we navigate to dashboard 
page; upon execution the results are displayed on the dashboard.

![leaking 
result](https://cloud.githubusercontent.com/assets/674497/9783325/15990682-57c1-11e5-82c4-da020f859e0a.png)

Author: Prabhjyot Singh <[email protected]>

Closes #441 from prabhjyotsingh/ZEPPELIN-293 and squashes the following commits:

996ee80 [Prabhjyot Singh] notebook results leaking to dashboard page


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/c7cf115d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/c7cf115d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/c7cf115d

Branch: refs/heads/master
Commit: c7cf115dd1945ea03fc0359c0f69b40d81dd4870
Parents: 80edf58
Author: Prabhjyot Singh <[email protected]>
Authored: Tue Nov 17 10:59:20 2015 +0530
Committer: Damien CORNEAU <[email protected]>
Committed: Thu Nov 19 12:45:20 2015 +0900

----------------------------------------------------------------------
 .../src/main/java/org/apache/zeppelin/socket/NotebookServer.java    | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/c7cf115d/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
----------------------------------------------------------------------
diff --git 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index e987461..654d782 100644
--- 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -359,6 +359,7 @@ public class NotebookServer extends WebSocketServlet 
implements
       conn.send(serializeMessage(new Message(OP.NOTE).put("note", note)));
       sendAllAngularObjects(note, conn);
     } else {
+      removeConnectionFromAllNote(conn);
       conn.send(serializeMessage(new Message(OP.NOTE).put("note", null)));
     }
   }

Reply via email to