Repository: incubator-zeppelin Updated Branches: refs/heads/master 576ead854 -> fab573fe9
[ZEPPELIN-447] Document review process and becoming a committer https://issues.apache.org/jira/browse/ZEPPELIN-477 Documenting review process and becoming a committer. Note that purpose of this PR is not improving those process but document what it looks like at the moment. Author: Lee moon soo <[email protected]> Closes #502 from Leemoonsoo/ZEPPELIN-477 and squashes the following commits: 2247402 [Lee moon soo] change order e5c936a [Lee moon soo] Remove spaces 6ebffb0 [Lee moon soo] Document review process and becoming a committer Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/fab573fe Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/fab573fe Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/fab573fe Branch: refs/heads/master Commit: fab573fe98a88b3fd1e247ae7c8cb7318f55a6e5 Parents: 576ead8 Author: Lee moon soo <[email protected]> Authored: Wed Dec 2 21:08:45 2015 +0900 Committer: Lee moon soo <[email protected]> Committed: Thu Dec 3 15:15:05 2015 +0900 ---------------------------------------------------------------------- CONTRIBUTING.md | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/fab573fe/CONTRIBUTING.md ---------------------------------------------------------------------- diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index aa69016..7dcc36e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,8 +11,30 @@ Contributing to Zeppelin (Source code, Documents, Image, Website) means you agre ## SourceControl Workflow Zeppelin follows [Fork & Pull] (https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request) model. + +## The Review Process + +When a Pull Request is submitted, it is being merged or rejected by following review process. + +* Anybody can be a reviewer and may comment on the change and suggest modifications. +* Reviewer can indicate that a patch looks suitable for merging with a comment such as : "Looks good", "LGTM", "+1". +* At least one indication of suitable for merging(eg. "LGTM") from committer is required to be merged. +* Pullrequest is open for 1 or 2 days for potential additional review, unless it's got enough indication of suitable for merging. +* Committer can initiate lazy consensus ("Merge if there is no more discusssion") and the code can be merged after certain time (normally 24 hours) when there is no review exists. +* Contributor can ping reviewers (including committer) by commenting 'Ready to review' or suitable indication. + + +## Becoming a Committer + +The PPMC adds new committers from the active contributors, based on their contribution to Zeppelin. The qualifications for new committers include: + +1. Sustained contributions : Committers should have a history of constant contributions to Zeppelin. +2. Quality of contributions : Committers more than any other community member should submit simple, well-tested, and well-designed patches. +3. Community involvement : Committers should have a constructive and friendly attitude in all community interactions. They should also be active on the dev, user list and reviewing patches. Also help new contributors and users. + + ## Setting up -Here are some things you will need to build and test Zeppelin. +Here are some things you will need to build and test Zeppelin. ### Software Configuration Management(SCM)
