Repository: incubator-zeppelin Updated Branches: refs/heads/master be8a74729 -> 0194d389a
ZEPPELIN-508 Interpreter binding cancel button doesn't work ### What is this PR for? Currently, when there is no change compared with before the interpreter binding setting status, the cancel button in binding page doesn't work. So I fixed this bug. ### What type of PR is it? Bug Fix ### Todos * [x] - Fix the cancel button in interpreter binding page. ### Is there a relevant Jira issue? [https://issues.apache.org/jira/browse/ZEPPELIN-508](https://issues.apache.org/jira/browse/ZEPPELIN-508) ### How should this be tested? Open the Zeppelin any notebook page -> Click the interpreter binding button 1. Don't change any binding setting and Just click the **cancel** button. 2. Or just click twice the interpreter binding button. ### Screenshots (if appropriate) After this PR applied,  ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Ryu Ah young <[email protected]> Closes #548 from AhyoungRyu/ZEPPELIN-508 and squashes the following commits: 3873545 [Ryu Ah young] Remove useless space between parenthesis 2d1d915 [Ryu Ah young] Fix else statement position 63eb0ae [Ryu Ah young] Remove space between colon e946e8d [Ryu Ah young] Remove useless dialog 62b1349 [Ryu Ah young] Fix typo : Notihing -> Nothing f39d4f5 [Ryu Ah young] ZEPPELIN-508 Interpreter binding cancel button doesn't work Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/0194d389 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/0194d389 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/0194d389 Branch: refs/heads/master Commit: 0194d389a5ffaf1094a350afb87a9bd341f0fa6e Parents: be8a747 Author: Ryu Ah young <[email protected]> Authored: Fri Dec 18 21:47:44 2015 -0800 Committer: Lee moon soo <[email protected]> Committed: Mon Dec 21 09:40:18 2015 +0900 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/notebook.controller.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/0194d389/zeppelin-web/src/app/notebook/notebook.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index b767e4e..1a4cff8 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -499,15 +499,17 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', function($scope, $ro if (isSettingDirty()) { BootstrapDialog.confirm({ title: '', - message: 'Changes will be discarded', + message: 'Changes will be discarded.', callback: function(result) { if (result) { - $scope.$apply(function () { + $scope.$apply(function() { $scope.showSetting = false; }); } } }); + } else { + $scope.showSetting = false; } };
