Repository: incubator-zeppelin
Updated Branches:
  refs/heads/branch-0.5.6 a7ab2be16 -> cf88d7cdb


fix + paragraph appearing in link

### What is this PR for?
Fix a bug where the + paragraph appears in link paragraph

### What type of PR is it?
Bug Fix

### Todos

### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-591

### How should this be tested?
Click link paragraph in a paragraph and move mouse below paragraph.

### Screenshots (if appropriate)

Before:
<img width="1424" alt="before" 
src="https://cloud.githubusercontent.com/assets/6380209/12211555/8c4ea0ce-b627-11e5-83fb-4d9273542bc8.png";>

After:
<img width="1416" alt="after" 
src="https://cloud.githubusercontent.com/assets/6380209/12211560/96642fa2-b627-11e5-90d0-f2381f1b3c24.png";>

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Michael Chen <[email protected]>

Closes #613 from MikeTYChen/ZEPPELIN-591 and squashes the following commits:

26dcea9 [Michael Chen] fix + paragraph appearing in link


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/cf88d7cd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/cf88d7cd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/cf88d7cd

Branch: refs/heads/branch-0.5.6
Commit: cf88d7cdbe960df784f45b182504a8211b0a6a7c
Parents: ed1cc02
Author: Michael Chen <[email protected]>
Authored: Fri Jan 8 16:45:31 2016 -0600
Committer: Alexander Bezzubov <[email protected]>
Committed: Mon Jan 11 22:13:14 2016 +0900

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/notebook.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/cf88d7cd/zeppelin-web/src/app/notebook/notebook.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.html 
b/zeppelin-web/src/app/notebook/notebook.html
index 227f8cd..41d1e1c 100644
--- a/zeppelin-web/src/app/notebook/notebook.html
+++ b/zeppelin-web/src/app/notebook/notebook.html
@@ -66,7 +66,7 @@ limitations under the License.
        ng-Init="init(currentParagraph)"
        ng-class="columnWidthClass(currentParagraph.config.colWidth)"
        class="paragraph-col">
-    <div class="new-paragraph" ng-click="insertNew('above')" 
ng-hide="viewOnly">
+    <div class="new-paragraph" ng-click="insertNew('above')" ng-hide="viewOnly 
|| asIframe">
       <h4 class="plus-sign">&#43;</h4>
     </div>
     <div id="{{currentParagraph.id}}_paragraphColumn"
@@ -75,7 +75,7 @@ limitations under the License.
                     'lastEmptyParagraph': !paragraph.text && 
!paragraph.result}"
          ng-hide="currentParagraph.config.tableHide && viewOnly">
     </div>
-    <div class="new-paragraph" ng-click="insertNew('below');" ng-hide="!$last 
|| viewOnly">
+    <div class="new-paragraph" ng-click="insertNew('below');" ng-hide="!$last 
|| viewOnly || asIframe ">
       <h4 class="plus-sign">&#43;</h4>
     </div>
   </div>

Reply via email to