Repository: incubator-zeppelin Updated Branches: refs/heads/master 0d157aebd -> 733c7eb6e
add keyboard shortcut for toggling run paragraph ### What is this PR for? Added a keyboard shortcut to toggle enable/disable of running a paragraph ### What type of PR is it? Improvement ### Todos ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-608 ### How should this be tested? Click in paragraph and press ctrl+alt+s ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Michael Chen <[email protected]> Closes #638 from MikeTYChen/ZEPPELIN-608 and squashes the following commits: 83cfa85 [Michael Chen] change shortcut key to ctrl+alt+r 1651cde [Michael Chen] Merge branch 'master' into ZEPPELIN-608 aa34352 [Michael Chen] add keyboard shortcut for toggling run paragraph Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/733c7eb6 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/733c7eb6 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/733c7eb6 Branch: refs/heads/master Commit: 733c7eb6e7d152a1708b84d55f6a3b5a183d9326 Parents: 0d157ae Author: Michael Chen <[email protected]> Authored: Tue Jan 19 09:37:20 2016 -0600 Committer: Felix Cheung <[email protected]> Committed: Thu Jan 21 14:50:27 2016 -0800 ---------------------------------------------------------------------- .../src/app/notebook/paragraph/paragraph.controller.js | 2 ++ .../src/components/modal-shortcut/modal-shortcut.html | 11 +++++++++++ 2 files changed, 13 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/733c7eb6/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 30c7ea4..c69f961 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -861,6 +861,8 @@ angular.module('zeppelinWebApp') $scope.insertNew('below'); } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 79) { // Ctrl + Alt + o $scope.toggleOutput(); + } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 82) { // Ctrl + Alt + r + $scope.toggleEnableDisable(); } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 69) { // Ctrl + Alt + e $scope.toggleEditor(); } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 77) { // Ctrl + Alt + m http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/733c7eb6/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html index 1191ec5..baeb011 100644 --- a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html +++ b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html @@ -125,6 +125,17 @@ limitations under the License. <div class="row"> <div class="col-md-4"> <div class="keys"> + <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">Alt</kbd> + <kbd class="kbd-dark">r</kbd> + </div> + </div> + <div class="col-md-8"> + Enable/Disable run paragraph + </div> + </div> + + <div class="row"> + <div class="col-md-4"> + <div class="keys"> <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">Alt</kbd> + <kbd class="kbd-dark">o</kbd> </div> </div>
