Repository: incubator-zeppelin Updated Branches: refs/heads/master c59229afc -> 39417c073
[HOTFIX] Add checkpoint() method implementation ### What is this PR for? While merging https://github.com/apache/incubator-zeppelin/pull/697, NotebookRepo API changed. And it breaks master branch. This PR implement checkpoint() method to fix it. ### What type of PR is it? Hot Fix ### Todos * [x] - Implement checkpoint() ### Is there a relevant Jira issue? ZEPPELIN-656 ### How should this be tested? build master branch ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #726 from Leemoonsoo/ZEPPELIN-656_hotfix and squashes the following commits: 6dbf024 [Lee moon soo] suported -> supported 3a61696 [Lee moon soo] Add checkpoint() method implementation Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/39417c07 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/39417c07 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/39417c07 Branch: refs/heads/master Commit: 39417c073b6d5d6d206ea021f0d68aeb3c81f859 Parents: c59229a Author: Lee moon soo <[email protected]> Authored: Thu Feb 18 17:37:24 2016 -0800 Committer: Lee moon soo <[email protected]> Committed: Thu Feb 18 17:52:03 2016 -0800 ---------------------------------------------------------------------- .../org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java | 6 ++++++ .../java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java | 2 +- .../org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/39417c07/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java index 2cb014f..9bec90a 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/AzureNotebookRepo.java @@ -204,4 +204,10 @@ public class AzureNotebookRepo implements NotebookRepo { @Override public void close() { } + + @Override + public void checkpoint(String noteId, String checkPointName) throws IOException { + // no-op + LOG.info("Checkpoint feature isn't supported in {}", this.getClass().toString()); + } } http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/39417c07/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java index a78dcb6..caf24fb 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java @@ -193,6 +193,6 @@ public class S3NotebookRepo implements NotebookRepo { @Override public void checkpoint(String noteId, String checkPointName) throws IOException { // no-op - LOG.info("Checkpoint feature isn't suported in {}", this.getClass().toString()); + LOG.info("Checkpoint feature isn't supported in {}", this.getClass().toString()); } } http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/39417c07/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java index 5f3676a..db074a4 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java @@ -247,7 +247,7 @@ public class VFSNotebookRepo implements NotebookRepo { @Override public void checkpoint(String noteId, String checkPointName) throws IOException { // no-op - logger.info("Checkpoint feature isn't suported in {}", this.getClass().toString()); + logger.info("Checkpoint feature isn't supported in {}", this.getClass().toString()); } }
