Repository: incubator-zeppelin Updated Branches: refs/heads/master 2a5eca38c -> 5ef7d745e
Bringing compiledScope for backward compatibility ### What is this PR for? compiledScope was not exposed API for users. However, some users were using compiledScope in their notebook and [ZEPPELIN-551](http://issues.apache.org/jira/browse/ZEPPELIN-551) break this notebook work by removing compiledScope. https://gist.github.com/granturing/a09aed4a302a7367be92 is an example notebook that uses compiledScope. This PR bringing compiledScope back for backward compatibility. ### What type of PR is it? Improvement ### Todos * [x] - Bringing compiledScope back for backward compatibility ### Is there a relevant Jira issue? compiledScope was removed by http://issues.apache.org/jira/browse/ZEPPELIN-551 ### How should this be tested? Test https://gist.github.com/granturing/a09aed4a302a7367be92 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #720 from Leemoonsoo/bringing_compiledScope and squashes the following commits: 0b6e5a8 [Lee moon soo] Bringing compiledScope for backward compatibility Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/5ef7d745 Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/5ef7d745 Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/5ef7d745 Branch: refs/heads/master Commit: 5ef7d745e339d75e336bbd6ff61fc7c3796b2d48 Parents: 2a5eca3 Author: Lee moon soo <[email protected]> Authored: Tue Feb 16 11:33:10 2016 -0800 Committer: Lee moon soo <[email protected]> Committed: Tue Feb 23 23:23:05 2016 -0800 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/5ef7d745/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index aeb942f..3b22b5b 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -21,9 +21,14 @@ angular.module('zeppelinWebApp') $scope.paragraph = null; $scope.originalText = ''; $scope.editor = null; + var paragraphScope = $rootScope.$new(true, $rootScope); + // to keep backward compatibility + $scope.compiledScope = paragraphScope; + var angularObjectRegistry = {}; + var editorModes = { 'ace/mode/scala': /^%spark/, 'ace/mode/sql': /^%(\w*\.)?\wql/,
