Repository: incubator-zeppelin Updated Branches: refs/heads/master 59aa3f025 -> ee5590ac3
Interpeter settings update must set the properties ### What is this PR for? If you change the intrepreter setting via the UI, the updated values are sent to the REST API but the JSON response coming back from the server contains the previous values (not the updated ones). This is a regression probably introduced recently. ### What type of PR is it? [Hot Fix] ### Todos Nil ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-725 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Eric Charles <[email protected]> Closes #768 from echarles/ZEPPELIN-725-Interpeter-settings-update-broken and squashes the following commits: 43ae3cb [Eric Charles] Interpeter update REST API must set the properties in the InterpreterSettings object Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/ee5590ac Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/ee5590ac Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/ee5590ac Branch: refs/heads/master Commit: ee5590ac3eb8eb0d5d28de677a1fc2a07ef434da Parents: 59aa3f0 Author: Eric Charles <[email protected]> Authored: Tue Mar 8 11:02:53 2016 +0100 Committer: Lee moon soo <[email protected]> Committed: Tue Mar 8 16:25:57 2016 -0800 ---------------------------------------------------------------------- .../java/org/apache/zeppelin/interpreter/InterpreterFactory.java | 1 + .../java/org/apache/zeppelin/interpreter/InterpreterSetting.java | 4 ++++ 2 files changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ee5590ac/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java index bf1377c..3221054 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java @@ -664,6 +664,7 @@ public class InterpreterFactory { intpsetting.getInterpreterGroup().destroy(); intpsetting.setOption(option); + intpsetting.setProperties(properties); intpsetting.setDependencies(dependencies); InterpreterGroup interpreterGroup = createInterpreterGroup(intpsetting.id(), option); http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ee5590ac/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java ---------------------------------------------------------------------- diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java index 5c93e3a..96c91a9 100644 --- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java +++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java @@ -129,6 +129,10 @@ public class InterpreterSetting { return properties; } + public void setProperties(Properties properties) { + this.properties = properties; + } + public List<Dependency> getDependencies() { if (dependencies == null) { return new LinkedList<Dependency>();
