anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87
and addresses deprecations
URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293386638
##########
File path: pom.xml
##########
@@ -48,9 +48,9 @@
<main.basedir>${project.basedir}</main.basedir>
- <armeria.version>0.86.0</armeria.version>
+ <armeria.version>0.87.0</armeria.version>
<!-- This is from armeria, but be careful to avoid >= v20 apis -->
- <guava.version>27.1-jre</guava.version>
+ <guava.version>28.0-jre</guava.version>
Review comment:
Don't remember exactly what this is but I wonder if it's removable since we
switched to `-protocol`. Armeria itself shades guava
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
