tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295103996
########## File path: zipkin-lens/scss/main.scss ########## @@ -39,16 +39,15 @@ $fa-font-path: "~@fortawesome/fontawesome-free/webfonts"; @import 'components/browser'; @import 'components/browser-header'; @import 'components/browser-results'; -@import 'components/condition-duration'; -@import 'components/condition-lookback'; -@import 'components/condition-name'; -@import 'components/condition-tags'; Review comment: We don't need these css files anymore, because material-ui's style-system is more excellent than this way of importing SCSS files. Please see: https://material-ui.com/styles/basics/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
