Author: shv
Date: Mon Jan 24 21:58:18 2011
New Revision: 1063006

URL: http://svn.apache.org/viewvc?rev=1063006&view=rev
Log:
HADOOP-7046. Fix Findbugs warning in Configuration. Contributed by Po Cheung.

Modified:
    hadoop/common/trunk/CHANGES.txt
    hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
    hadoop/common/trunk/src/test/test-patch.properties

Modified: hadoop/common/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=1063006&r1=1063005&r2=1063006&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Mon Jan 24 21:58:18 2011
@@ -451,6 +451,8 @@ Release 0.22.0 - Unreleased
 
     HADOOP-7089. Fix link resolution logic in hadoop-config.sh. (eli)
 
+    HADOOP-7046. Fix Findbugs warning in Configuration. (Po Cheung via shv)
+
 Release 0.21.1 - Unreleased
 
   IMPROVEMENTS

Modified: hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
URL: 
http://svn.apache.org/viewvc/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java?rev=1063006&r1=1063005&r2=1063006&view=diff
==============================================================================
--- hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 
(original)
+++ hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java Mon 
Jan 24 21:58:18 2011
@@ -1591,7 +1591,6 @@ public class Configuration implements It
   public void writeXml(Writer out) throws IOException {
     Document doc = asXmlDocument();
 
-    Properties properties = getProps();
     try {
       DOMSource source = new DOMSource(doc);
       StreamResult result = new StreamResult(out);

Modified: hadoop/common/trunk/src/test/test-patch.properties
URL: 
http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/test-patch.properties?rev=1063006&r1=1063005&r2=1063006&view=diff
==============================================================================
--- hadoop/common/trunk/src/test/test-patch.properties (original)
+++ hadoop/common/trunk/src/test/test-patch.properties Mon Jan 24 21:58:18 2011
@@ -14,5 +14,5 @@
 # limitations under the License.
 
 OK_RELEASEAUDIT_WARNINGS=1
-OK_FINDBUGS_WARNINGS=1
+OK_FINDBUGS_WARNINGS=0
 OK_JAVADOC_WARNINGS=6


Reply via email to