Author: suresh Date: Thu Sep 20 04:06:11 2012 New Revision: 1387853 URL: http://svn.apache.org/viewvc?rev=1387853&view=rev Log: HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li.
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Thu Sep 20 04:06:11 2012 @@ -103,6 +103,9 @@ Trunk (Unreleased) HADOOP-8736. Add Builder for building RPC server. (Brandon Li via Suresh) + HADOOP-8814. Replace string equals "" by String#isEmpty(). + (Brandon Li via suresh) + BUG FIXES HADOOP-8177. MBeans shouldn't try to register when it fails to create MBeanName. Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java Thu Sep 20 04:06:11 2012 @@ -1073,7 +1073,7 @@ public class Configuration implements It */ public boolean getBoolean(String name, boolean defaultValue) { String valueString = getTrimmed(name); - if (null == valueString || "".equals(valueString)) { + if (null == valueString || valueString.isEmpty()) { return defaultValue; } @@ -1140,7 +1140,7 @@ public class Configuration implements It */ public Pattern getPattern(String name, Pattern defaultValue) { String valString = get(name); - if (null == valString || "".equals(valString)) { + if (null == valString || valString.isEmpty()) { return defaultValue; } try { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java Thu Sep 20 04:06:11 2012 @@ -153,9 +153,9 @@ public class ReconfigurationServlet exte StringEscapeUtils.unescapeHtml(req.getParameter(rawParam)); if (value != null) { if (value.equals(newConf.getRaw(param)) || value.equals("default") || - value.equals("null") || value.equals("")) { + value.equals("null") || value.isEmpty()) { if ((value.equals("default") || value.equals("null") || - value.equals("")) && + value.isEmpty()) && oldConf.getRaw(param) != null) { out.println("<p>Changed \"" + StringEscapeUtils.escapeHtml(param) + "\" from \"" + @@ -163,7 +163,7 @@ public class ReconfigurationServlet exte "\" to default</p>"); reconf.reconfigureProperty(param, null); } else if (!value.equals("default") && !value.equals("null") && - !value.equals("") && + !value.isEmpty() && (oldConf.getRaw(param) == null || !oldConf.getRaw(param).equals(value))) { // change from default or value to different value Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java Thu Sep 20 04:06:11 2012 @@ -2003,7 +2003,7 @@ public final class FileContext { String filename = inPathPattern.toUri().getPath(); // path has only zero component - if ("".equals(filename) || Path.SEPARATOR.equals(filename)) { + if (filename.isEmpty() || Path.SEPARATOR.equals(filename)) { Path p = inPathPattern.makeQualified(uri, null); return getFileStatus(new Path[]{p}); } Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java Thu Sep 20 04:06:11 2012 @@ -1597,7 +1597,7 @@ public abstract class FileSystem extends String filename = pathPattern.toUri().getPath(); // path has only zero component - if ("".equals(filename) || Path.SEPARATOR.equals(filename)) { + if (filename.isEmpty() || Path.SEPARATOR.equals(filename)) { return getFileStatus(new Path[]{pathPattern}); } Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java Thu Sep 20 04:06:11 2012 @@ -68,7 +68,7 @@ public class Path implements Comparable // Add a slash to parent's path so resolution is compatible with URI's URI parentUri = parent.uri; String parentPath = parentUri.getPath(); - if (!(parentPath.equals("/") || parentPath.equals(""))) { + if (!(parentPath.equals("/") || parentPath.isEmpty())) { try { parentUri = new URI(parentUri.getScheme(), parentUri.getAuthority(), parentUri.getPath()+"/", null, parentUri.getFragment()); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java Thu Sep 20 04:06:11 2012 @@ -492,7 +492,7 @@ public class RawLocalFileSystem extends * onwer.equals(""). */ private boolean isPermissionLoaded() { - return !super.getOwner().equals(""); + return !super.getOwner().isEmpty(); } RawLocalFileStatus(File f, long defaultBlockSize, FileSystem fs) { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java Thu Sep 20 04:06:11 2012 @@ -128,7 +128,7 @@ public class RawLocalFs extends Delegate try { FileStatus fs = getFileStatus(f); // If f refers to a regular file or directory - if ("".equals(target)) { + if (target.isEmpty()) { return fs; } // Otherwise f refers to a symlink @@ -150,7 +150,7 @@ public class RawLocalFs extends Delegate * the readBasicFileAttributes method in java.nio.file.attributes * when available. */ - if (!"".equals(target)) { + if (!target.isEmpty()) { return new FileStatus(0, false, 0, 0, 0, 0, FsPermission.getDefault(), "", "", new Path(target), f); } Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java Thu Sep 20 04:06:11 2012 @@ -300,7 +300,7 @@ public class NativeS3FileSystem extends } private static String pathToKey(Path path) { - if (path.toUri().getScheme() != null && "".equals(path.toUri().getPath())) { + if (path.toUri().getScheme() != null && path.toUri().getPath().isEmpty()) { // allow uris without trailing slash after bucket to refer to root, // like s3n://mybucket return ""; Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java Thu Sep 20 04:06:11 2012 @@ -276,7 +276,7 @@ public class ActiveStandbyElector implem String pathParts[] = znodeWorkingDir.split("/"); Preconditions.checkArgument(pathParts.length >= 1 && - "".equals(pathParts[0]), + pathParts[0].isEmpty(), "Invalid path: %s", znodeWorkingDir); StringBuilder sb = new StringBuilder(); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java Thu Sep 20 04:06:11 2012 @@ -241,7 +241,7 @@ public class SshFenceByTcpPort extends C sshPort = DEFAULT_SSH_PORT; // Parse optional user and ssh port - if (arg != null && !"".equals(arg)) { + if (arg != null && !arg.isEmpty()) { Matcher m = USER_PORT_RE.matcher(arg); if (!m.matches()) { throw new BadFencingConfigurationException( Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java Thu Sep 20 04:06:11 2012 @@ -192,7 +192,7 @@ public class DefaultStringifier<T> imple String[] parts = itemStr.split(SEPARATOR); for (String part : parts) { - if (!part.equals("")) + if (!part.isEmpty()) list.add(stringifier.fromString(part)); } Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java Thu Sep 20 04:06:11 2012 @@ -2105,7 +2105,7 @@ public class TFile { } public boolean isSorted() { - return !strComparator.equals(""); + return !strComparator.isEmpty(); } public String getComparatorString() { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java Thu Sep 20 04:06:11 2012 @@ -129,7 +129,7 @@ public abstract class MetricsDynamicMBea @Override public Object getAttribute(String attributeName) throws AttributeNotFoundException, MBeanException, ReflectionException { - if (attributeName == null || attributeName.equals("")) + if (attributeName == null || attributeName.isEmpty()) throw new IllegalArgumentException(); updateMbeanInfoIfMetricsListChanged(); @@ -197,7 +197,7 @@ public abstract class MetricsDynamicMBea public Object invoke(String actionName, Object[] parms, String[] signature) throws MBeanException, ReflectionException { - if (actionName == null || actionName.equals("")) + if (actionName == null || actionName.isEmpty()) throw new IllegalArgumentException(); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java Thu Sep 20 04:06:11 2012 @@ -144,7 +144,7 @@ public class CsvRecordInput implements R @Override public void startRecord(String tag) throws IOException { - if (tag != null && !"".equals(tag)) { + if (tag != null && !tag.isEmpty()) { char c1 = (char) stream.read(); char c2 = (char) stream.read(); if (c1 != 's' || c2 != '{') { @@ -156,7 +156,7 @@ public class CsvRecordInput implements R @Override public void endRecord(String tag) throws IOException { char c = (char) stream.read(); - if (tag == null || "".equals(tag)) { + if (tag == null || tag.isEmpty()) { if (c != '\n' && c != '\r') { throw new IOException("Error deserializing record."); } else { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java Thu Sep 20 04:06:11 2012 @@ -115,7 +115,7 @@ public class CsvRecordOutput implements @Override public void startRecord(Record r, String tag) throws IOException { - if (tag != null && !"".equals(tag)) { + if (tag != null && ! tag.isEmpty()) { printCommaUnlessFirst(); stream.print("s{"); isFirst = true; @@ -124,7 +124,7 @@ public class CsvRecordOutput implements @Override public void endRecord(Record r, String tag) throws IOException { - if (tag == null || "".equals(tag)) { + if (tag == null || tag.isEmpty()) { stream.print("\n"); isFirst = true; } else { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java Thu Sep 20 04:06:11 2012 @@ -212,7 +212,7 @@ public class SecurityUtil { private static String replacePattern(String[] components, String hostname) throws IOException { String fqdn = hostname; - if (fqdn == null || fqdn.equals("") || fqdn.equals("0.0.0.0")) { + if (fqdn == null || fqdn.isEmpty() || fqdn.equals("0.0.0.0")) { fqdn = getLocalHostName(); } return components[0] + "/" + fqdn.toLowerCase() + "@" + components[2]; Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java Thu Sep 20 04:06:11 2012 @@ -992,7 +992,7 @@ public class UserGroupInformation { @InterfaceAudience.Public @InterfaceStability.Evolving public static UserGroupInformation createRemoteUser(String user) { - if (user == null || "".equals(user)) { + if (user == null || user.isEmpty()) { throw new IllegalArgumentException("Null user"); } Subject subject = new Subject(); @@ -1027,7 +1027,7 @@ public class UserGroupInformation { @InterfaceStability.Evolving public static UserGroupInformation createProxyUser(String user, UserGroupInformation realUser) { - if (user == null || "".equals(user)) { + if (user == null || user.isEmpty()) { throw new IllegalArgumentException("Null user"); } if (realUser == null) { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java Thu Sep 20 04:06:11 2012 @@ -88,7 +88,7 @@ public class ServiceAuthorizationManager String clientPrincipal = null; if (krbInfo != null) { String clientKey = krbInfo.clientPrincipal(); - if (clientKey != null && !clientKey.equals("")) { + if (clientKey != null && !clientKey.isEmpty()) { try { clientPrincipal = SecurityUtil.getServerPrincipal( conf.get(clientKey), addr); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java Thu Sep 20 04:06:11 2012 @@ -87,12 +87,12 @@ extends TokenIdentifier { */ @Override public UserGroupInformation getUser() { - if ( (owner == null) || ("".equals(owner.toString()))) { + if ( (owner == null) || (owner.toString().isEmpty())) { return null; } final UserGroupInformation realUgi; final UserGroupInformation ugi; - if ((realUser == null) || ("".equals(realUser.toString())) + if ((realUser == null) || (realUser.toString().isEmpty()) || realUser.equals(owner)) { ugi = realUgi = UserGroupInformation.createRemoteUser(owner.toString()); } else { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java Thu Sep 20 04:06:11 2012 @@ -265,7 +265,7 @@ extends AbstractDelegationTokenIdentifie throw new InvalidToken("User " + renewer + " tried to renew an expired token"); } - if ((id.getRenewer() == null) || ("".equals(id.getRenewer().toString()))) { + if ((id.getRenewer() == null) || (id.getRenewer().toString().isEmpty())) { throw new AccessControlException("User " + renewer + " tried to renew a token without " + "a renewer"); @@ -321,7 +321,7 @@ extends AbstractDelegationTokenIdentifie HadoopKerberosName cancelerKrbName = new HadoopKerberosName(canceller); String cancelerShortName = cancelerKrbName.getShortName(); if (!canceller.equals(owner) - && (renewer == null || "".equals(renewer.toString()) || !cancelerShortName + && (renewer == null || renewer.toString().isEmpty() || !cancelerShortName .equals(renewer.toString()))) { throw new AccessControlException(canceller + " is not authorized to cancel the token"); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java Thu Sep 20 04:06:11 2012 @@ -63,7 +63,7 @@ public class HostsFileReader { // Everything from now on is a comment break; } - if (!nodes[i].equals("")) { + if (!nodes[i].isEmpty()) { LOG.info("Adding " + nodes[i] + " to the list of hosts from " + filename); set.add(nodes[i]); // might need to add canonical name } @@ -80,13 +80,13 @@ public class HostsFileReader { public synchronized void refresh() throws IOException { LOG.info("Refreshing hosts (include/exclude) list"); - if (!includesFile.equals("")) { + if (!includesFile.isEmpty()) { Set<String> newIncludes = new HashSet<String>(); readFileToSet(includesFile, newIncludes); // switch the new hosts that are to be included includes = newIncludes; } - if (!excludesFile.equals("")) { + if (!excludesFile.isEmpty()) { Set<String> newExcludes = new HashSet<String>(); readFileToSet(excludesFile, newExcludes); // switch the excluded hosts Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java Thu Sep 20 04:06:11 2012 @@ -348,7 +348,7 @@ public class StringUtils { * @return an array of <code>String</code> values */ public static String[] getTrimmedStrings(String str){ - if (null == str || "".equals(str.trim())) { + if (null == str || str.trim().isEmpty()) { return emptyStringArray; } @@ -408,7 +408,7 @@ public class StringUtils { String str, char separator) { // String.split returns a single empty result for splitting the empty // string. - if ("".equals(str)) { + if (str.isEmpty()) { return new String[]{""}; } ArrayList<String> strList = new ArrayList<String>(); Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java Thu Sep 20 04:06:11 2012 @@ -67,7 +67,7 @@ public class TestNativeIO { assertEquals(System.getProperty("user.name"), stat.getOwner()); assertNotNull(stat.getGroup()); - assertTrue(!"".equals(stat.getGroup())); + assertTrue(!stat.getGroup().isEmpty()); assertEquals("Stat mode field should indicate a regular file", NativeIO.Stat.S_IFREG, stat.getMode() & NativeIO.Stat.S_IFMT); } @@ -96,7 +96,7 @@ public class TestNativeIO { NativeIO.Stat stat = NativeIO.fstat(fos.getFD()); assertEquals(System.getProperty("user.name"), stat.getOwner()); assertNotNull(stat.getGroup()); - assertTrue(!"".equals(stat.getGroup())); + assertTrue(!stat.getGroup().isEmpty()); assertEquals("Stat mode field should indicate a regular file", NativeIO.Stat.S_IFREG, stat.getMode() & NativeIO.Stat.S_IFMT); } catch (Throwable t) { Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java Thu Sep 20 04:06:11 2012 @@ -112,7 +112,7 @@ public class TestSaslRPC { } @Override public UserGroupInformation getUser() { - if ("".equals(realUser.toString())) { + if (realUser.toString().isEmpty()) { return UserGroupInformation.createRemoteUser(tokenid.toString()); } else { UserGroupInformation realUgi = UserGroupInformation Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java?rev=1387853&r1=1387852&r2=1387853&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java (original) +++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java Thu Sep 20 04:06:11 2012 @@ -231,7 +231,8 @@ public class TestStringUtils extends Uni assertArrayEquals(expectedArray, StringUtils.getTrimmedStrings(pathologicalDirList2)); assertArrayEquals(emptyArray, StringUtils.getTrimmedStrings(emptyList1)); - assertArrayEquals(emptyArray, StringUtils.getTrimmedStrings(emptyList2)); + String[] estring = StringUtils.getTrimmedStrings(emptyList2); + assertArrayEquals(emptyArray, estring); } @Test