HDFS-7583. Fix findbug in TransferFsImage.java (Contributed by Vinayakumar B)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/e6ab984b Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/e6ab984b Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/e6ab984b Branch: refs/heads/HDFS-EC Commit: e6ab984be40c9d5136f6100ffebd4379f34023b5 Parents: 1bd23bc Author: Vinayakumar B <[email protected]> Authored: Tue Jan 6 09:31:35 2015 +0530 Committer: Zhe Zhang <[email protected]> Committed: Mon Jan 12 10:17:59 2015 -0800 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 2 ++ .../org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/e6ab984b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 48e3695..e9d6ad2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -642,6 +642,8 @@ Release 2.7.0 - UNRELEASED HDFS-7572. TestLazyPersistFiles#testDnRestartWithSavedReplicas is flaky on Windows. (Arpit Agarwal via cnauroth) + HDFS-7583. Fix findbug in TransferFsImage.java (vinayakumarb) + Release 2.6.1 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/e6ab984b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java index 1f52ff7..c1e9d7f 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java @@ -574,11 +574,12 @@ public class TransferFsImage { LOG.info("Deleting temporary files: " + files); for (File file : files) { - file.delete(); // ignore the return value + if (!file.delete()) { + LOG.warn("Deleting " + file + " has failed"); + } } } - private static MD5Hash parseMD5Header(HttpURLConnection connection) { String header = connection.getHeaderField(MD5_HEADER); return (header != null) ? new MD5Hash(header) : null;
