YARN-3237. AppLogAggregatorImpl fails to log error cause. Contributed by Rushabh S Shah
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/f56c65bb Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/f56c65bb Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/f56c65bb Branch: refs/heads/HDFS-7285 Commit: f56c65bb3eb9436b67de2df63098e26589e70e56 Parents: 3c5ff07 Author: Xuan <xg...@apache.org> Authored: Fri Feb 20 14:02:40 2015 -0800 Committer: Xuan <xg...@apache.org> Committed: Fri Feb 20 14:02:40 2015 -0800 ---------------------------------------------------------------------- hadoop-yarn-project/CHANGES.txt | 3 +++ .../containermanager/logaggregation/AppLogAggregatorImpl.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/f56c65bb/hadoop-yarn-project/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index c028043..359e647 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -312,6 +312,9 @@ Release 2.7.0 - UNRELEASED YARN-3230. Clarify application states on the web UI. (Jian He via wangda) + YARN-3237. AppLogAggregatorImpl fails to log error cause. + (Rushabh S Shah via xgong) + OPTIMIZATIONS YARN-2990. FairScheduler's delay-scheduling always waits for node-local and http://git-wip-us.apache.org/repos/asf/hadoop/blob/f56c65bb/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java index 8eb00f4..787422b 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java @@ -248,7 +248,7 @@ public class AppLogAggregatorImpl implements AppLogAggregator { } catch (IOException e1) { LOG.error("Cannot create writer for app " + this.applicationId - + ". Skip log upload this time. "); + + ". Skip log upload this time. ", e1); return; } @@ -549,7 +549,7 @@ public class AppLogAggregatorImpl implements AppLogAggregator { writer.append(logKey, logValue); } catch (Exception e) { LOG.error("Couldn't upload logs for " + containerId - + ". Skipping this container."); + + ". Skipping this container.", e); return new HashSet<Path>(); } this.uploadedFileMeta.addAll(logValue