HDFS-9372. Remove dead code in DataStorage.recoverTransitionRead. Contributed by Duo Zhang.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/efc73d78 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/efc73d78 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/efc73d78 Branch: refs/heads/HDFS-8707 Commit: efc73d7896e65a8a03d226ac21309257a7dc126c Parents: ff47f35 Author: Haohui Mai <[email protected]> Authored: Thu Nov 5 10:00:01 2015 -0800 Committer: Haohui Mai <[email protected]> Committed: Thu Nov 5 10:00:01 2015 -0800 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../apache/hadoop/hdfs/server/datanode/DataStorage.java | 12 ------------ 2 files changed, 3 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/efc73d78/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index f5c6f0f..7246a57 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -1671,6 +1671,9 @@ Release 2.8.0 - UNRELEASED HDFS-9308. Add truncateMeta() and deleteMeta() to MiniDFSCluster. (Tony Wu via lei) + HDFS-9372. Remove dead code in DataStorage.recoverTransitionRead. + (Duo Zhang via wheat9) + BUG FIXES HDFS-7501. TransactionsSinceLastCheckpoint can be negative on SBNs. http://git-wip-us.apache.org/repos/asf/hadoop/blob/efc73d78/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java index 8b8c6c5..707f1a5 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java @@ -44,7 +44,6 @@ import org.apache.hadoop.hdfs.server.common.Storage; import org.apache.hadoop.hdfs.server.common.StorageInfo; import org.apache.hadoop.hdfs.server.protocol.DatanodeStorage; import org.apache.hadoop.hdfs.server.protocol.NamespaceInfo; -import org.apache.hadoop.io.nativeio.NativeIO; import org.apache.hadoop.util.Daemon; import org.apache.hadoop.util.DiskChecker; @@ -106,9 +105,6 @@ public class DataStorage extends Storage { * versions of Datanodes we cannot make this field a UUID. */ private String datanodeUuid = null; - - // Flag to ensure we only initialize storage once - private boolean initialized = false; // Maps block pool IDs to block pool storage private final Map<String, BlockPoolSliceStorage> bpStorageMap @@ -462,14 +458,6 @@ public class DataStorage extends Storage { */ void recoverTransitionRead(DataNode datanode, NamespaceInfo nsInfo, Collection<StorageLocation> dataDirs, StartupOption startOpt) throws IOException { - if (this.initialized) { - LOG.info("DataNode version: " + HdfsServerConstants.DATANODE_LAYOUT_VERSION - + " and NameNode layout version: " + nsInfo.getLayoutVersion()); - this.storageDirs = new ArrayList<StorageDirectory>(dataDirs.size()); - // mark DN storage is initialized - this.initialized = true; - } - if (addStorageLocations(datanode, nsInfo, dataDirs, startOpt).isEmpty()) { throw new IOException("All specified directories are failed to load."); }
