HDFS-10603. Fix flaky tests in org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot. Contributed by Yiqun Lin.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/85f4b862 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/85f4b862 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/85f4b862 Branch: refs/heads/YARN-2915 Commit: 85f4b86233158ada5f71b77b7783ce0604e0b3ad Parents: ebc4a5d Author: Akira Ajisaka <[email protected]> Authored: Tue Jul 19 13:49:24 2016 -0700 Committer: Subru Krishnan <[email protected]> Committed: Tue Jul 19 14:39:33 2016 -0700 ---------------------------------------------------------------------- .../snapshot/TestOpenFilesWithSnapshot.java | 21 +++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/85f4b862/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java index 812bcc5..7b7c34a 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java @@ -69,7 +69,7 @@ public class TestOpenFilesWithSnapshot { // delete files separately fs.delete(new Path("/test/test/test2"), true); fs.delete(new Path("/test/test/test3"), true); - cluster.restartNameNode(); + restartNameNode(); } @Test @@ -79,7 +79,7 @@ public class TestOpenFilesWithSnapshot { // delete parent directory fs.delete(new Path("/test/test"), true); - cluster.restartNameNode(); + restartNameNode(); } @Test @@ -87,11 +87,7 @@ public class TestOpenFilesWithSnapshot { Path path = new Path("/test"); doWriteAndAbort(fs, path); fs.delete(new Path("/test/test"), true); - NameNode nameNode = cluster.getNameNode(); - NameNodeAdapter.enterSafeMode(nameNode, false); - NameNodeAdapter.saveNamespace(nameNode); - NameNodeAdapter.leaveSafeMode(nameNode); - cluster.restartNameNode(true); + restartNameNode(); // read snapshot file after restart String test2snapshotPath = Snapshot.getSnapshotPath(path.toString(), @@ -108,11 +104,7 @@ public class TestOpenFilesWithSnapshot { doWriteAndAbort(fs, path); fs.delete(new Path("/test/test/test2"), true); fs.delete(new Path("/test/test/test3"), true); - NameNode nameNode = cluster.getNameNode(); - NameNodeAdapter.enterSafeMode(nameNode, false); - NameNodeAdapter.saveNamespace(nameNode); - NameNodeAdapter.leaveSafeMode(nameNode); - cluster.restartNameNode(true); + restartNameNode(); // read snapshot file after restart String test2snapshotPath = Snapshot.getSnapshotPath(path.toString(), @@ -203,6 +195,11 @@ public class TestOpenFilesWithSnapshot { fs.rename(new Path("/test/test"), new Path("/test/test-renamed")); fs.delete(new Path("/test/test-renamed"), true); + restartNameNode(); + } + + private void restartNameNode() throws Exception { + cluster.triggerBlockReports(); NameNode nameNode = cluster.getNameNode(); NameNodeAdapter.enterSafeMode(nameNode, false); NameNodeAdapter.saveNamespace(nameNode); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
