Repository: hadoop Updated Branches: refs/heads/trunk ff7513235 -> 859bd159a
HDFS-11333. Print a user friendly error message when plugins are not found. Contributed by Wei-Chiu Chuang. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/859bd159 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/859bd159 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/859bd159 Branch: refs/heads/trunk Commit: 859bd159ae554174200334b5eb1d7e8dbef958ad Parents: ff75132 Author: Wei-Chiu Chuang <weic...@apache.org> Authored: Wed Feb 15 02:50:35 2017 -0800 Committer: Wei-Chiu Chuang <weic...@apache.org> Committed: Wed Feb 15 02:50:35 2017 -0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hdfs/server/datanode/DataNode.java | 10 +++++++++- .../org/apache/hadoop/hdfs/server/namenode/NameNode.java | 11 +++++++++-- 2 files changed, 18 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/859bd159/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java index 9ed80ef..5db41bd 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java @@ -921,7 +921,15 @@ public class DataNode extends ReconfigurableBase } private void startPlugins(Configuration conf) { - plugins = conf.getInstances(DFS_DATANODE_PLUGINS_KEY, ServicePlugin.class); + try { + plugins = conf.getInstances(DFS_DATANODE_PLUGINS_KEY, + ServicePlugin.class); + } catch (RuntimeException e) { + String pluginsValue = conf.get(DFS_DATANODE_PLUGINS_KEY); + LOG.error("Unable to load DataNode plugins. Specified list of plugins: " + + pluginsValue, e); + throw e; + } for (ServicePlugin p: plugins) { try { p.start(this); http://git-wip-us.apache.org/repos/asf/hadoop/blob/859bd159/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java index 1752cf7..e7841f0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java @@ -809,8 +809,15 @@ public class NameNode extends ReconfigurableBase implements httpServer.setFSImage(getFSImage()); } rpcServer.start(); - plugins = conf.getInstances(DFS_NAMENODE_PLUGINS_KEY, - ServicePlugin.class); + try { + plugins = conf.getInstances(DFS_NAMENODE_PLUGINS_KEY, + ServicePlugin.class); + } catch (RuntimeException e) { + String pluginsValue = conf.get(DFS_NAMENODE_PLUGINS_KEY); + LOG.error("Unable to load NameNode plugins. Specified list of plugins: " + + pluginsValue, e); + throw e; + } for (ServicePlugin p: plugins) { try { p.start(this); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org