YARN-1728. Regression test for guice-undecoded pathInfo in YARN WebApp. (Yuanbo Liu via gera)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/480b4dd5 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/480b4dd5 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/480b4dd5 Branch: refs/heads/YARN-5734 Commit: 480b4dd574d0355bf6c976a38bb45cb86adb2714 Parents: d269b48 Author: Gera Shegalov <g...@apache.org> Authored: Tue Feb 28 09:22:29 2017 -0800 Committer: Gera Shegalov <g...@apache.org> Committed: Tue Feb 28 09:27:22 2017 -0800 ---------------------------------------------------------------------- .../apache/hadoop/yarn/webapp/TestWebApp.java | 31 +++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/480b4dd5/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java index 9454002..db50dd3 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java @@ -27,12 +27,12 @@ import static org.apache.hadoop.yarn.webapp.view.JQueryUI._TH; import static org.apache.hadoop.yarn.webapp.view.JQueryUI.initID; import static org.apache.hadoop.yarn.webapp.view.JQueryUI.tableInit; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import java.io.InputStream; import java.net.HttpURLConnection; import java.net.URL; +import java.net.URLEncoder; import org.apache.commons.lang.ArrayUtils; import org.apache.hadoop.conf.Configuration; @@ -263,6 +263,35 @@ public class TestWebApp { } } + @Test public void testEncodedUrl() throws Exception { + WebApp app = + WebApps.$for("test", TestWebApp.class, this, "ws").start(new WebApp() { + @Override + public void setup() { + bind(MyTestJAXBContextResolver.class); + bind(MyTestWebService.class); + + route("/:foo", FooController.class); + } + }); + String baseUrl = baseUrl(app); + + try { + // Test encoded url + String rawPath = "localhost:8080"; + String encodedUrl = baseUrl + "test/" + + URLEncoder.encode(rawPath, "UTF-8"); + assertEquals("foo" + rawPath, getContent(encodedUrl).trim()); + + rawPath = "@;%$"; + encodedUrl = baseUrl + "test/" + + URLEncoder.encode(rawPath, "UTF-8"); + assertEquals("foo" + rawPath, getContent(encodedUrl).trim()); + } finally { + app.stop(); + } + } + @Test public void testRobotsText() throws Exception { WebApp app = WebApps.$for("test", TestWebApp.class, this, "ws").start(new WebApp() { --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org