Repository: hadoop Updated Branches: refs/heads/branch-2 8ed230c80 -> d77cada18
YARN-3760. FSDataOutputStream leak in AggregatedLogFormat.LogWriter.close(). Contributed by Haibo Chen. (cherry picked from commit c26ccf1adb3a72df3f68e1150b86b813c691203a) (cherry picked from commit 9d9087a67ad599e678948d5c1036e51cb8cf5e3a) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/d77cada1 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/d77cada1 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/d77cada1 Branch: refs/heads/branch-2 Commit: d77cada182ef805679dc79498d6b6cc6e7f6b6d4 Parents: 8ed230c Author: Junping Du <junping...@apache.org> Authored: Wed Apr 12 09:34:34 2017 -0700 Committer: Junping Du <junping...@apache.org> Committed: Wed Apr 12 13:54:58 2017 -0700 ---------------------------------------------------------------------- .../hadoop/yarn/logaggregation/AggregatedLogFormat.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/d77cada1/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java index aa29386..a2e1243 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java @@ -540,14 +540,15 @@ public class AggregatedLogFormat { @Override public void close() { - if (writer != null) { - try { + try { + if (writer != null) { writer.close(); - } catch (IOException e) { - LOG.warn("Exception closing writer", e); } + } catch (Exception e) { + LOG.warn("Exception closing writer", e); + } finally { + IOUtils.closeStream(this.fsDataOStream); } - IOUtils.closeStream(fsDataOStream); } } --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org