HDFS-12744. More logs when short-circuit read is failed and disabled. Contributed by Weiwei Yang.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/56b88b06 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/56b88b06 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/56b88b06 Branch: refs/heads/YARN-1011 Commit: 56b88b06705441f6f171eec7fb2fa77946ca204b Parents: 20304b9 Author: Weiwei Yang <w...@apache.org> Authored: Wed Nov 1 16:41:45 2017 +0800 Committer: Weiwei Yang <w...@apache.org> Committed: Wed Nov 1 16:41:45 2017 +0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java | 3 ++- .../java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/56b88b06/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java index 5a22c33..6f3fc61 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/BlockReaderFactory.java @@ -646,7 +646,8 @@ public class BlockReaderFactory implements ShortCircuitReplicaCreator { default: LOG.warn(this + ": unknown response code " + resp.getStatus() + " while attempting to set up short-circuit access. " + - resp.getMessage()); + resp.getMessage() + ". Disabling short-circuit read for DataNode " + + datanode + " temporarily."); clientContext.getDomainSocketFactory() .disableShortCircuitForPath(pathInfo.getPath()); return null; http://git-wip-us.apache.org/repos/asf/hadoop/blob/56b88b06/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java index 3216a78..b78fc9c 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java @@ -387,6 +387,8 @@ class DataXceiver extends Receiver implements Runnable { } catch (IOException e) { bld.setStatus(ERROR); bld.setMessage(e.getMessage()); + LOG.error("Request short-circuit read file descriptor" + + " failed with unknown error.", e); } bld.build().writeDelimitedTo(socketOut); if (fis != null) { --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
