Repository: hadoop Updated Branches: refs/heads/trunk 0ef639235 -> c7101fe21
YARN-7879. NM user is unable to access the application filecache due to permissions. Contributed by Jason Lowe. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/c7101fe2 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/c7101fe2 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/c7101fe2 Branch: refs/heads/trunk Commit: c7101fe21ba7b9aa589f0a9266ed34356f30b35f Parents: 0ef6392 Author: Miklos Szegedi <szege...@apache.org> Authored: Fri Feb 2 11:38:21 2018 -0800 Committer: Miklos Szegedi <szege...@apache.org> Committed: Fri Feb 2 16:48:57 2018 -0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/yarn/util/FSDownload.java | 7 ++----- .../test/java/org/apache/hadoop/yarn/util/TestFSDownload.java | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/c7101fe2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java index 508440a..d203f65 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java @@ -401,7 +401,7 @@ public class FSDownload implements Callable<Path> { } final Path destinationTmp = new Path(destDirPath + "_tmp"); - createDir(destinationTmp, PRIVATE_DIR_PERMS); + createDir(destinationTmp, cachePerms); Path dFinal = files.makeQualified(new Path(destinationTmp, sCopy.getName())); try { @@ -416,10 +416,7 @@ public class FSDownload implements Callable<Path> { } }); } - Path destinationTmpfilesQualified = files.makeQualified(destinationTmp); - changePermissions( - destinationTmpfilesQualified.getFileSystem(conf), - destinationTmpfilesQualified); + changePermissions(dFinal.getFileSystem(conf), dFinal); files.rename(destinationTmp, destDirPath, Rename.OVERWRITE); if (LOG.isDebugEnabled()) { http://git-wip-us.apache.org/repos/asf/hadoop/blob/c7101fe2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java index fa8c039..08d6189 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java @@ -451,7 +451,7 @@ public class TestFSDownload { FileStatus status = files.getFileStatus(localized.getParent()); FsPermission perm = status.getPermission(); assertEquals("Cache directory permissions are incorrect", - new FsPermission((short)0700), perm); + new FsPermission((short)0755), perm); status = files.getFileStatus(localized); perm = status.getPermission(); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org