YARN-8391. Investigate AllocationFileLoaderService.reloadListener locking issue. Contributed by Szilard Nemeth.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/9a9e9695 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/9a9e9695 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/9a9e9695 Branch: refs/heads/HDDS-4 Commit: 9a9e969570f23b627f9571819f388916d8fd7ec9 Parents: 4939ffe Author: Miklos Szegedi <miklos.szeg...@cloudera.com> Authored: Wed Jun 20 10:29:12 2018 -0700 Committer: Miklos Szegedi <miklos.szeg...@cloudera.com> Committed: Wed Jun 20 10:59:33 2018 -0700 ---------------------------------------------------------------------- .../scheduler/fair/AllocationFileLoaderService.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/9a9e9695/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java index 56cc887..3300948 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java @@ -114,7 +114,9 @@ public class AllocationFileLoaderService extends AbstractService { reloadThread = new Thread(() -> { while (running) { try { - reloadListener.onCheck(); + synchronized (this) { + reloadListener.onCheck(); + } long time = clock.getTime(); long lastModified = fs.getFileStatus(allocFile).getModificationTime(); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
