YARN-8515. container-executor can crash with SIGPIPE after nodemanager restart. Contributed by Jim Brennan
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/17118f44 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/17118f44 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/17118f44 Branch: refs/heads/YARN-7402 Commit: 17118f446c2387aa796849da8b69a845d9d307d3 Parents: d185072 Author: Jason Lowe <jl...@apache.org> Authored: Fri Jul 13 10:05:25 2018 -0500 Committer: Jason Lowe <jl...@apache.org> Committed: Fri Jul 13 10:05:25 2018 -0500 ---------------------------------------------------------------------- .../src/main/native/container-executor/impl/main.c | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/17118f44/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c index 2099ace..6ab522f 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c @@ -31,6 +31,7 @@ #include <unistd.h> #include <stdlib.h> #include <string.h> +#include <signal.h> static void display_usage(FILE *stream) { fprintf(stream, @@ -112,6 +113,11 @@ static void open_log_files() { if (ERRORFILE == NULL) { ERRORFILE = stderr; } + + // There may be a process reading from stdout/stderr, and if it + // exits, we will crash on a SIGPIPE when we try to write to them. + // By ignoring SIGPIPE, we can handle the EPIPE instead of crashing. + signal(SIGPIPE, SIG_IGN); } /* Flushes and closes log files */ --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
