This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 192cad9 HADOOP-17018. Intermittent failing of
ITestAbfsStreamStatistics in ABFS (#1990)
192cad9 is described below
commit 192cad9ee24779cbd7735fdf9da0fba90255d546
Author: Mehakmeet Singh <[email protected]>
AuthorDate: Thu May 7 16:45:28 2020 +0530
HADOOP-17018. Intermittent failing of ITestAbfsStreamStatistics in ABFS
(#1990)
Contributed by: Mehakmeet Singh
In some cases, ABFS-prefetch thread runs in the background which returns
some bytes from the buffer and gives an extra readOp. Thus, making readOps
values arbitrary and giving intermittent failures in some cases. Hence, readOps
values of 2 or 3 are seen in different setups.
---
.../hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git
a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java
b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java
index b749f49..51531f6 100644
---
a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java
+++
b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java
@@ -84,12 +84,21 @@ public class ITestAbfsStreamStatistics extends
AbstractAbfsIntegrationTest {
LOG.info("Result of Read operation : {}", result);
/*
- Testing if 2 read_ops value is coming after reading full content from a
- file (3 if anything to read from Buffer too).
- Reason: read() call gives read_ops=1,
- reading from AbfsClient(http GET) gives read_ops=2.
+ * Testing if 2 read_ops value is coming after reading full content
+ * from a file (3 if anything to read from Buffer too). Reason: read()
+ * call gives read_ops=1, reading from AbfsClient(http GET) gives
+ * read_ops=2.
+ *
+ * In some cases ABFS-prefetch thread runs in the background which
+ * returns some bytes from buffer and gives an extra readOp.
+ * Thus, making readOps values arbitrary and giving intermittent
+ * failures in some cases. Hence, readOps values of 2 or 3 is seen in
+ * different setups.
+ *
*/
- assertReadWriteOps("read", 2, statistics.getReadOps());
+ assertTrue(String.format("The actual value of %d was not equal to the "
+ + "expected value of 2 or 3", statistics.getReadOps()),
+ statistics.getReadOps() == 2 || statistics.getReadOps() == 3);
} finally {
IOUtils.cleanupWithLogger(LOG, inForOneOperation,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
