This is an automated email from the ASF dual-hosted git repository.
jbrennan pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new 41d58d1 Revert "HADOOP-17306. RawLocalFileSystem's lastModifiedTime()
looses milli seconds in JDK < 10.b09 (#2387)"
41d58d1 is described below
commit 41d58d190dceac1fe28388d26a7583ece54f2feb
Author: Jim Brennan <[email protected]>
AuthorDate: Thu Nov 5 17:31:39 2020 +0000
Revert "HADOOP-17306. RawLocalFileSystem's lastModifiedTime() looses milli
seconds in JDK < 10.b09 (#2387)"
This reverts commit e21b81276e04138301dae1aa88da7bc4a51722fd.
---
.../org/apache/hadoop/fs/RawLocalFileSystem.java | 11 +++-------
.../hadoop/fs/TestRawLocalFileSystemContract.java | 24 ----------------------
2 files changed, 3 insertions(+), 32 deletions(-)
diff --git
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
index 1294096..72eeb99 100644
---
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
+++
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
@@ -72,12 +72,7 @@ public class RawLocalFileSystem extends FileSystem {
public static void useStatIfAvailable() {
useDeprecatedFileStatus = !Stat.isAvailable();
}
-
- @VisibleForTesting
- static void setUseDeprecatedFileStatus(boolean useDeprecatedFileStatus) {
- RawLocalFileSystem.useDeprecatedFileStatus = useDeprecatedFileStatus;
- }
-
+
public RawLocalFileSystem() {
workingDir = getInitialWorkingDirectory();
}
@@ -705,8 +700,8 @@ public class RawLocalFileSystem extends FileSystem {
DeprecatedRawLocalFileStatus(File f, long defaultBlockSize, FileSystem fs)
throws IOException {
super(f.length(), f.isDirectory(), 1, defaultBlockSize,
- Files.getLastModifiedTime(f.toPath()).toMillis(),
- getLastAccessTime(f),null, null, null,
+ f.lastModified(), getLastAccessTime(f),
+ null, null, null,
new Path(f.getPath()).makeQualified(fs.getUri(),
fs.getWorkingDirectory()));
}
diff --git
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestRawLocalFileSystemContract.java
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestRawLocalFileSystemContract.java
index cb45c9e..b51419d 100644
---
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestRawLocalFileSystemContract.java
+++
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestRawLocalFileSystemContract.java
@@ -203,28 +203,4 @@ public class TestRawLocalFileSystemContract extends
FileSystemContractBaseTest {
}
}
- @Test
- public void testMTimeAtime() throws IOException {
- RawLocalFileSystem.setUseDeprecatedFileStatus(true);
- try {
- Path testDir = getTestBaseDir();
- String testFilename = "testmtime";
- Path path = new Path(testDir, testFilename);
- Path file = new Path(path, "file");
- fs.create(file);
- long now = System.currentTimeMillis();
- long mtime = (now % 1000 == 0) ? now + 1 : now;
- long atime = (now % 1000 == 0) ? now + 2 : now;
- fs.setTimes(file, mtime, atime);
- FileStatus fileStatus = fs.getFileStatus(file);
- if (!Shell.MAC) {
- // HADOOP-17306 ; Skip MacOS because HFS+ does not support
- // milliseconds for mtime.
- assertEquals(mtime, fileStatus.getModificationTime());
- }
- assertEquals(atime, fileStatus.getAccessTime());
- } finally {
- RawLocalFileSystem.useStatIfAvailable();
- }
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
