This is an automated email from the ASF dual-hosted git repository. surendralilhore pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push: new dd8e540 Addendum HADOOP-17770 WASB : Support disabling buffered reads in positional reads - Added the invalid SpotBugs warning to findbugs-exclude.xml (#3223) dd8e540 is described below commit dd8e540670754c059812ccecf089b144b6e07a47 Author: Anoop Sam John <anoopsamj...@gmail.com> AuthorDate: Sun Jul 25 13:10:27 2021 +0530 Addendum HADOOP-17770 WASB : Support disabling buffered reads in positional reads - Added the invalid SpotBugs warning to findbugs-exclude.xml (#3223) --- hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml index b750b8b..fa6085f 100644 --- a/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml +++ b/hadoop-tools/hadoop-azure/dev-support/findbugs-exclude.xml @@ -83,4 +83,17 @@ <Bug pattern="IS2_INCONSISTENT_SYNC" /> </Match> + <!-- This field is instance of BlockBlobInputStream and read(long, byte[], int, int) + calls it's Super class method when 'fs.azure.block.blob.buffered.pread.disable' + is configured false. Super class FSInputStream's implementation is having + proper synchronization. + When 'fs.azure.block.blob.buffered.pread.disable' is true, we want a lock free + implementation of blob read. Here we don't use any of the InputStream's + shared resource (buffer) and also don't change any cursor position etc. + So its safe to go with unsynchronized way of read. --> + <Match> + <Class name="org.apache.hadoop.fs.azure.NativeAzureFileSystem$NativeAzureFsInputStream" /> + <Field name="in" /> + <Bug pattern="IS2_INCONSISTENT_SYNC" /> + </Match> </FindBugsFilter> --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org