This is an automated email from the ASF dual-hosted git repository. shuzirra pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push: new 44bab51 YARN-10849 Clarify testcase documentation for TestServiceAM#testContainersReleasedWhenPreLaunchFails. Contributed by Szilard Nemeth 44bab51 is described below commit 44bab51be44e31224dabbfa548eb27ea5fb2f916 Author: Gergely Pollak <shuzi...@apache.org> AuthorDate: Wed Aug 4 15:43:07 2021 +0200 YARN-10849 Clarify testcase documentation for TestServiceAM#testContainersReleasedWhenPreLaunchFails. Contributed by Szilard Nemeth --- .../java/org/apache/hadoop/yarn/service/TestServiceAM.java | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java index fa96642..c988658 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java @@ -480,9 +480,17 @@ public class TestServiceAM extends ServiceTestUtils{ am.stop(); } - // Test to verify that the containers are released and the - // component instance is added to the pending queue when building the launch - // context fails. + /** + This test verifies that the containers are released and the + component instance is added to the pending queue when building the launch + context fails. + Here, we intentionally have an artifact that doesn't have an id. + This will cause TarballProviderService.processArtifact + to throw an IllegalArgumentException because the Path object is + constructed from the id of the artifact. + In case the id is set to null or unset so it is effectively null, + Path.checkPathArg throws an IllegalArgumentException. + **/ @Test(timeout = 30000) public void testContainersReleasedWhenPreLaunchFails() throws Exception { --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org