(hadoop) 10/17: HADOOP-18889. Third party storage followup. (#6186)

[ahmar]

This is an automated email from the ASF dual-hosted git repository.

ahmar pushed a commit to branch feature-HADOOP-18073-sdk-v2-upgrade-3.6-aws
in repository https://gitbox.apache.org/repos/asf/hadoop.git

commit e14b08b030d3b6a4742390ea4fd2917932279320
Author: Steve Loughran <ste...@cloudera.com>
AuthorDate: Tue Oct 24 18:17:52 2023 +0100

    HADOOP-18889. Third party storage followup. (#6186)
    
    
    Followup to HADOOP-18889 third party store support;
    
    Fix some minor review comments which came in after the merge.
---
 .../src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java  |  2 +-
 .../main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java | 10 ----------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git 
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
 
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
index ff2a35a6315a..4a0c8594341d 100644
--- 
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
+++ 
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
@@ -1358,7 +1358,7 @@ public class S3AFileSystem extends FileSystem implements 
StreamCapabilities,
     public String getBucketLocation(String bucketName) throws IOException {
       final String region = trackDurationAndSpan(
           STORE_EXISTS_PROBE, bucketName, null, () ->
-              once("getBucketLocation()", bucketName, () ->
+              invoker.retry("getBucketLocation()", bucketName, true, () ->
                   // If accessPoint then region is known from Arn
                   accessPoint != null
                       ? accessPoint.getRegion()
diff --git 
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java
 
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java
index 5d34688cebe1..21c390c07940 100644
--- 
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java
+++ 
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/SignerFactory.java
@@ -81,16 +81,6 @@ public final class SignerFactory {
     SIGNERS.put(signerType, signerClass);
   }
 
-  /**
-   * Check if the signer has already been registered.
-   * @param signerType signer to get
-   * @throws IllegalArgumentException if the signer type is unknown.
-   */
-  public static void verifySignerRegistered(String signerType) {
-    checkArgument(isSignerRegistered(signerType),
-        "unknown signer type: %s", signerType);
-  }
-
   /**
    * Check if the signer has already been registered.
    * @param signerType signer to get


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org