On Fri, Sep 14, 2012 at 11:23 AM, Aaron T. Myers <a...@cloudera.com> wrote: > > So, if you see a test case fail by reaching the Surefire fork timeout, > please file a JIRA to add a JUnit timeout for that test. If when adding a > test case you think that it might time out, please add a JUnit timeout.
I'd go one step further: If you add any test that isn't a true "unit" test (ie it relies on any mulithreading, either explicitly or by using miniclusters, etc), you should add a timeout. Even if it has to be conservative (like 5 minutes on a test that you expect only runs 10 seconds), it seems better than waiting for it to timeout and then later having to go back and add one. -Todd -- Todd Lipcon Software Engineer, Cloudera
