Ted Yu created HADOOP-11414:
-------------------------------
Summary: Close of Reader should be enclosed in finally block in
FileBasedIPList#readLines()
Key: HADOOP-11414
URL: https://issues.apache.org/jira/browse/HADOOP-11414
Project: Hadoop Common
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
{code}
Reader fileReader = new InputStreamReader(
new FileInputStream(file), Charsets.UTF_8);
BufferedReader bufferedReader = new BufferedReader(fileReader);
List<String> lines = new ArrayList<String>();
String line = null;
while ((line = bufferedReader.readLine()) != null) {
lines.add(line);
}
bufferedReader.close();
{code}
Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
