Hi Alan,

If it flags a warning on a line of code that your patch touches, then go
ahead and trim the whitespace.  If you find that it flags a warning on a
line of code in the surrounding diff context, but not something that
you're actually changing, then don't bother.  I agree that doing a mass
clean-up would make a patch noisy and more difficult to review.

There are some known issues with false positives on the whitespace check
right now.  Fixes are in progress.

Thanks!

--Chris Nauroth




On 6/19/15, 9:07 AM, "Alan Burlison" <alan.burli...@oracle.com> wrote:

>While running the dev-support/test-patch.sh I got some warnings about
>trailing whitespace. I'll fix the 2 that I introduced but what about all
>the others in the files I've touched, fix or leave? I can fix easily
>enough but it makes the patches rather noisy.
>
>-- 
>Alan Burlison
>--

Reply via email to