Github user aajisaka commented on the pull request:
https://github.com/apache/hadoop/pull/89#issuecomment-205168263
Thank you for rebasing! Mostly looks good to me. Two comments:
* Can we separate the patch into common change and hdfs change? That way
the patch becomes smaller and the review becomes easier.
* I'm thinking we should replace not only `test.build.data` but also
`test.build.dir` with `GenericTestUtils.getTestDir`. I'm okay with doing this
by separate jira(s).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
