Thanks for the clarification, Andrew. Yes, I'll add a comment about the results of my "testing". :)
On Fri, Apr 22, 2016 at 2:06 AM, Andrew Wang <andrew.w...@cloudera.com> wrote: > Squashing means force pushing, so please don't do that per ASF policies. > The normal recommendation is just not to fix it, commit message typos > aren't that a big deal. What I do is leave a comment on the JIRA to make it > easier for people to track down the commit. > > I found INFRA-11136 where we supposedly protected trunk and also > INFRA-11236 about getting this in place for the branch-Xs. Larry, could you > update INFRA-11236 with your empirical testing? Would be good to get these > branches protected again for the future. > > Thanks, > Andrew > > > On Thu, Apr 21, 2016 at 9:42 PM, larry mccay <lmc...@apache.org> wrote: > > > I believe that he squashed my attempted --amend into a single commit on > > branch-2.8. > > Not sure about trunk and branch-2. > > > > Thanks for the clarification on the formatting. > > I will comply in the future. > > > > For such issues, is a dev@ email first better than trying to "fix" it? > > > > Again, sorry for the inconvenience. > > > > On Fri, Apr 22, 2016 at 12:10 AM, Andrew Wang <andrew.w...@cloudera.com> > > wrote: > > > > > What does "fix" mean? We aren't supposed to force push to non-feature > > > branches, and actually thought this was disabled. > > > > > > Also FYI for the future, we normally format our commit messages with > > > periods, e.g.: > > > > > > HADOOP-13011. Clearly Document the Password Details for Keystore-based > > > Credential Providers. > > > > > > > > > On Thu, Apr 21, 2016 at 8:26 PM, larry mccay <lmc...@apache.org> > wrote: > > > > > > > All - > > > > > > > > My first hadoop commit for HADOOP-13011 inadvertently referenced the > > > wrong > > > > JIRA (HADOOP-13001) in the commit message. > > > > > > > > Owen O'Malley helped me out by fixing the history on all 3 branches: > > > trunk, > > > > branch-2, branch-2.8. The message is correct now in the current > history > > > but > > > > you may need to rebase to the current history for things to align > > > properly. > > > > > > > > I apologize for the inconvenience. > > > > > > > > thanks, > > > > > > > > --larry > > > > > > > > > >
