If there is no other volunteer until tomorrow morning CET we wil do a try.
John Zhuge <jzh...@cloudera.com> írta:
>Thanks Andras.
>
>Created a new https://issues.apache.org/jira/browse/HADOOP-13160 and
>uploaded a patch.
>
>Tested on Ubuntu but I don't have access to a Windows environment. Could
>someone kindly test the patch in Windows?
>
>Thanks,
>
>John Zhuge
>Software Engineer, Cloudera
>
>On Mon, May 16, 2016 at 11:15 AM, Bokor Andras <bok...@freemail.hu> wrote:
>
>> In Haddop JUnit tests not always follow Test.*.java pattern. Instead I
>> suggest the following suppress:
>> <*suppress **checks=**"JavadocPackage" **files=**"/src/test/.*"*/>
>>
>> This needs to be tested on Windows due to the slashes.
>>
>> John Zhuge <jzh...@cloudera.com> írta:
>>
>>
>> http://stackoverflow.com/questions/5871020/different-checkstyle-rules-for-main-and-test-in-maven
>>
>> http://stackoverflow.com/questions/25894431/checkstyle-different-rules-for-different-files
>>
>> So something like this for Hadoop:
>>
>> <suppress checks="CheckInappropiateForTests" files="Test.*\.java"/>
>>
>> I will test it this approach.
>>
>>
>> John Zhuge
>> Software Engineer, Cloudera
>>
>> On Mon, May 16, 2016 at 9:39 AM, Chris Nauroth <cnaur...@hortonworks.com>
>> wrote:
>>
>> > I'm in favor of disabling this, but I'm not sure how. It looks
>> > like
>> > HADOOP-12701 recently enabled Checkstyle in src/test, so we hadn't seen
>> > this before. Unfortunately, I can't find a way to keep Checkstyle
>> > generally on for src/test, but with different rules from src/main.
>> >
>> > http://checkstyle.sourceforge.net/config_javadoc.html
>> >
>> >
>> > Does anyone else have an idea?
>> >
>> >
>> > --Chris Nauroth
>> >
>> >
>> >
>> >
>> > On 5/16/16, 6:34 AM, "Steve Loughran" <ste...@hortonworks.com> wrote:
>> >
>> > >
>> > >I've got checkstyle rejecting a patch as there's no
>> > >package-info.java
>> > >file ‹in src/test
>> > >
>> > >https://issues.apache.org/jira/browse/HADOOP-13130
>> > >
>> > >I'm happy to argue the merits of the package-info files in production
>> > >code: they can be good, if people put in the effort to write and
>> > >maintain, but not for tests. Can we get this turned off?
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
>> > For additional commands, e-mail: common-dev-h...@hadoop.apache.org
>> >
>> >
>>
>
