[ https://issues.apache.org/jira/browse/HADOOP-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu resolved HADOOP-13489. ----------------------------- Resolution: Won't Fix After adjusting hbase code, the problem is gone. > DistCp may incorrectly return success status when the underlying Job failed > --------------------------------------------------------------------------- > > Key: HADOOP-13489 > URL: https://issues.apache.org/jira/browse/HADOOP-13489 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Labels: distcp > Attachments: HADOOP-13489.v1.patch, HADOOP-13489.v2.patch, > HADOOP-13489.v3.patch, MapReduceBackupCopyService.java, > testIncrementalBackup-8-12-rethrow.txt, testIncrementalBackup-8-12.txt, > TestIncrementalBackup-output.txt > > > I was troubleshooting HBASE-14450 where at the end of BackupdistCp#execute(), > distcp job was marked unsuccessful (BackupdistCp is a wrapper of DistCp). > Yet in IncrementalTableBackupProcedure#incrementalCopy(), the return value > from copyService.copy() was 0. > Here is related code from DistCp: > {code} > try { > execute(); > } catch (InvalidInputException e) { > LOG.error("Invalid input: ", e); > return DistCpConstants.INVALID_ARGUMENT; > } catch (DuplicateFileException e) { > LOG.error("Duplicate files in input path: ", e); > return DistCpConstants.DUPLICATE_INPUT; > } catch (AclsNotSupportedException e) { > LOG.error("ACLs not supported on at least one file system: ", e); > return DistCpConstants.ACLS_NOT_SUPPORTED; > } catch (XAttrsNotSupportedException e) { > LOG.error("XAttrs not supported on at least one file system: ", e); > return DistCpConstants.XATTRS_NOT_SUPPORTED; > } catch (Exception e) { > LOG.error("Exception encountered ", e); > return DistCpConstants.UNKNOWN_ERROR; > } > return DistCpConstants.SUCCESS; > {code} > We don't check whether the Job returned by execute() was successful - we rely > on all failure cases going through the last catch clause but there may be > special case. > Even if the Job fails, DistCpConstants.SUCCESS is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org